From: David Lin <yu-hao.lin@nxp.com>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
kvalo@kernel.org, francesco@dolcini.it,
tsung-hsien.hsieh@nxp.com, David Lin <yu-hao.lin@nxp.com>
Subject: [PATCH v7 07/12] wifi: mwifiex: fixed TLV error for station add cmd.
Date: Tue, 28 Nov 2023 16:31:10 +0800 [thread overview]
Message-ID: <20231128083115.613235-8-yu-hao.lin@nxp.com> (raw)
In-Reply-To: <20231128083115.613235-1-yu-hao.lin@nxp.com>
TLV commands setting for host command HostCmd_CMD_ADD_NEW_STATION is
not correct. This issue will set wrong station information to firmware.
Without this patch, transmission will get 50-70% low throughput for host
mlme AP mode.
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
---
.../net/wireless/marvell/mwifiex/uap_cmd.c | 52 +++++++++----------
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
index c1133da28bc6..eb7e39146b8a 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
@@ -809,7 +809,7 @@ static int mwifiex_cmd_uap_add_station(struct mwifiex_private *priv,
u8 qos_capa;
u16 header_len = sizeof(struct mwifiex_ie_types_header);
u16 tlv_len;
- struct mwifiex_ie_types_header *tlv;
+ struct mwifiex_ie_types_data *tlv;
struct mwifiex_ie_types_sta_flag *sta_flag;
int i;
@@ -846,45 +846,44 @@ static int mwifiex_cmd_uap_add_station(struct mwifiex_private *priv,
cmd->size += sizeof(struct mwifiex_ie_types_sta_flag);
if (params->ext_capab_len) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_EXT_CAPABILITY);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_EXT_CAPABILITY);
tlv_len = params->ext_capab_len;
- tlv->len = cpu_to_le16(tlv_len);
- memcpy(tlv + header_len, params->ext_capab, tlv_len);
+ tlv->header.len = cpu_to_le16(tlv_len);
+ memcpy(tlv->data, params->ext_capab, tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
}
if (params->link_sta_params.supported_rates_len) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_SUPP_RATES);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_SUPP_RATES);
tlv_len = params->link_sta_params.supported_rates_len;
- tlv->len = cpu_to_le16(tlv_len);
- memcpy(tlv + header_len,
+ tlv->header.len = cpu_to_le16(tlv_len);
+ memcpy(tlv->data,
params->link_sta_params.supported_rates, tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
}
if (params->uapsd_queues || params->max_sp) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_QOS_CAPA);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_QOS_CAPA);
tlv_len = sizeof(qos_capa);
- tlv->len = cpu_to_le16(tlv_len);
+ tlv->header.len = cpu_to_le16(tlv_len);
qos_capa = params->uapsd_queues | (params->max_sp << 5);
- memcpy(tlv + header_len, &qos_capa, tlv_len);
+ memcpy(tlv->data, &qos_capa, tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
sta_ptr->is_wmm_enabled = 1;
}
if (params->link_sta_params.ht_capa) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_HT_CAPABILITY);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_HT_CAPABILITY);
tlv_len = sizeof(struct ieee80211_ht_cap);
- tlv->len = cpu_to_le16(tlv_len);
- memcpy(tlv + header_len, params->link_sta_params.ht_capa,
- tlv_len);
+ tlv->header.len = cpu_to_le16(tlv_len);
+ memcpy(tlv->data, params->link_sta_params.ht_capa, tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
sta_ptr->is_11n_enabled = 1;
@@ -896,23 +895,22 @@ static int mwifiex_cmd_uap_add_station(struct mwifiex_private *priv,
}
if (params->link_sta_params.vht_capa) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_VHT_CAPABILITY);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_VHT_CAPABILITY);
tlv_len = sizeof(struct ieee80211_vht_cap);
- tlv->len = cpu_to_le16(tlv_len);
- memcpy(tlv + header_len, params->link_sta_params.vht_capa,
- tlv_len);
+ tlv->header.len = cpu_to_le16(tlv_len);
+ memcpy(tlv->data, params->link_sta_params.vht_capa, tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
sta_ptr->is_11ac_enabled = 1;
}
if (params->link_sta_params.opmode_notif_used) {
- tlv = (struct mwifiex_ie_types_header *)pos;
- tlv->type = cpu_to_le16(WLAN_EID_OPMODE_NOTIF);
+ tlv = (struct mwifiex_ie_types_data *)pos;
+ tlv->header.type = cpu_to_le16(WLAN_EID_OPMODE_NOTIF);
tlv_len = sizeof(u8);
- tlv->len = cpu_to_le16(tlv_len);
- memcpy(tlv + header_len, params->link_sta_params.opmode_notif,
+ tlv->header.len = cpu_to_le16(tlv_len);
+ memcpy(tlv->data, params->link_sta_params.opmode_notif,
tlv_len);
pos += (header_len + tlv_len);
cmd->size += (header_len + tlv_len);
--
2.25.1
next prev parent reply other threads:[~2023-11-28 8:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 8:31 [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme David Lin
2023-11-28 8:31 ` [PATCH v7 01/12] " David Lin
2023-11-28 22:51 ` kernel test robot
2023-11-28 8:31 ` [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3 David Lin
2023-12-01 10:15 ` Francesco Dolcini
2023-12-01 15:05 ` Jeff Johnson
2023-12-01 23:18 ` [EXT] " David Lin
2023-12-01 22:41 ` David Lin
2023-11-28 8:31 ` [PATCH v7 03/12] wifi: mwifiex: fixed reassocation " David Lin
2023-12-01 10:17 ` Francesco Dolcini
2023-12-01 22:44 ` [EXT] " David Lin
2023-11-28 8:31 ` [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req David Lin
2023-12-01 10:18 ` Francesco Dolcini
2023-12-01 22:47 ` [EXT] " David Lin
2023-12-14 2:16 ` Brian Norris
2023-12-14 2:20 ` David Lin
2023-11-28 8:31 ` [PATCH v7 05/12] wifi: mwifiex: supported host mlme for AP mode David Lin
2023-11-28 8:31 ` [PATCH v7 06/12] wifi: mwifiex: added mac address for AP config David Lin
2023-12-01 10:31 ` Francesco Dolcini
2023-12-01 22:50 ` [EXT] " David Lin
2023-12-03 16:13 ` Jeff Johnson
2023-12-04 1:56 ` David Lin
2023-11-28 8:31 ` David Lin [this message]
2023-12-01 10:36 ` [PATCH v7 07/12] wifi: mwifiex: fixed TLV error for station add cmd Francesco Dolcini
2023-12-01 22:52 ` [EXT] " David Lin
2023-11-28 8:31 ` [PATCH v7 08/12] wifi: mwifiex: fixed the way to handle assoc timeout David Lin
2023-12-01 10:37 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 09/12] wifi: mwifiex: fixed the way to handle link lost David Lin
2023-12-01 10:38 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 10/12] wifi: mwifiex: fixed AP issue without host mlme David Lin
2023-12-01 10:39 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments David Lin
2023-12-01 10:40 ` Francesco Dolcini
2023-11-28 8:31 ` [PATCH v7 12/12] wifi: mwifiex: fixed compile and coding errors David Lin
2023-12-01 10:43 ` Francesco Dolcini
2023-12-01 11:49 ` [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme Francesco Dolcini
2023-12-01 12:25 ` Kalle Valo
2023-12-01 23:12 ` [EXT] " David Lin
2023-12-01 23:05 ` David Lin
2023-12-05 19:46 ` Francesco Dolcini
2023-12-06 1:49 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128083115.613235-8-yu-hao.lin@nxp.com \
--to=yu-hao.lin@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®