* [PATCH] hwmon: peci: Bump timeout
@ 2023-11-30 9:04 Patrick Rudolph
2023-12-01 4:05 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Rudolph @ 2023-11-30 9:04 UTC (permalink / raw)
To: Iwona Winiarska
Cc: naresh.solanki, Patrick Rudolph, Jean Delvare, Guenter Roeck,
linux-hwmon, linux-kernel
The PECI CPU sensors are available as soon as the CPU is powered,
however the PECI DIMM sensors are available after DRAM has been
trained and thresholds have been written by host firmware.
The default timeout of 30 seconds isn't enough for modern multisocket
platforms utilizing DDR5 memory to bring up the memory and enable PECI
sensor data.
Bump the default timeout to 10 minutes in case the system starts
without cached DDR5 training data.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
drivers/hwmon/peci/dimmtemp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/peci/dimmtemp.c b/drivers/hwmon/peci/dimmtemp.c
index 5ca4d04e4b14..4a72e9712408 100644
--- a/drivers/hwmon/peci/dimmtemp.c
+++ b/drivers/hwmon/peci/dimmtemp.c
@@ -47,7 +47,7 @@
#define GET_TEMP_MAX(x) (((x) & DIMM_TEMP_MAX) >> 8)
#define GET_TEMP_CRIT(x) (((x) & DIMM_TEMP_CRIT) >> 16)
-#define NO_DIMM_RETRY_COUNT_MAX 5
+#define NO_DIMM_RETRY_COUNT_MAX 120
struct peci_dimmtemp;
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: peci: Bump timeout
2023-11-30 9:04 [PATCH] hwmon: peci: Bump timeout Patrick Rudolph
@ 2023-12-01 4:05 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2023-12-01 4:05 UTC (permalink / raw)
To: Patrick Rudolph
Cc: Iwona Winiarska, naresh.solanki, Jean Delvare, linux-hwmon, linux-kernel
On Thu, Nov 30, 2023 at 10:04:21AM +0100, Patrick Rudolph wrote:
> The PECI CPU sensors are available as soon as the CPU is powered,
> however the PECI DIMM sensors are available after DRAM has been
> trained and thresholds have been written by host firmware.
>
> The default timeout of 30 seconds isn't enough for modern multisocket
> platforms utilizing DDR5 memory to bring up the memory and enable PECI
> sensor data.
> Bump the default timeout to 10 minutes in case the system starts
> without cached DDR5 training data.
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Applied. Note that the affected driver (peci/dimmtemp) should be
listed in the subject. I updated that.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-01 4:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-30 9:04 [PATCH] hwmon: peci: Bump timeout Patrick Rudolph
2023-12-01 4:05 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®