From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: rostedt@goodmis.org, tglx@linutronix.de, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com, zyhtheonly@gmail.com,
zyhtheonly@yeah.net
Subject: Re: [PATCH v2] sched/cputime: exclude ktimers threads in irqtime_account_irq
Date: Thu, 30 Nov 2023 13:00:36 +0100 [thread overview]
Message-ID: <20231130120036.5EpZn4eo@linutronix.de> (raw)
In-Reply-To: <20231130094130.GA12116@didi-ThinkCentre-M930t-N000>
On 2023-11-30 17:41:47 [+0800], tiozhang wrote:
> In CONFIG_PREEMPT_RT kernel, ktimers also calls __do_softirq,
> so when accounting CPUTIME_SOFTIRQ, ktimers need to be excluded
> as well as ksoftirqd.
> Also add this_cpu_ktimers to keep consistency with this_cpu_ksoftirqd.
I'm still not sure what the benefit here is. It says align with
ksoftirqd but why? Why don't we account softirq time for ksoftirqd (and
should continue to do so for ktimersd)?
ktimers runs almost all the time in softirq context. So does every
force-threaded interrupt. Should we exclude them, too?
Sebastian
next prev parent reply other threads:[~2023-11-30 12:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 6:34 [PATCH] sched/cputime: exclude ktimer " tiozhang
2023-11-27 18:07 ` Steven Rostedt
2023-11-30 9:41 ` [PATCH v2] sched/cputime: exclude ktimers " tiozhang
2023-11-30 12:00 ` Sebastian Andrzej Siewior [this message]
2023-12-01 7:27 ` Yuanhan Zhang
2023-12-01 7:32 ` Sebastian Andrzej Siewior
2023-12-01 8:05 ` [PATCH v3] sched/cputime: let ktimers align with ksoftirqd in accounting CPUTIME_SOFTIRQ tiozhang
2023-12-01 16:16 ` Sebastian Andrzej Siewior
2023-12-02 10:28 ` Yuanhan Zhang
2023-12-05 15:31 ` Sebastian Andrzej Siewior
2023-12-07 10:43 ` Yuanhan Zhang
2023-12-07 15:35 ` Steven Rostedt
2023-12-07 17:19 ` Yuanhan Zhang
2023-12-07 18:18 ` Steven Rostedt
2023-12-08 9:26 ` Sebastian Andrzej Siewior
2023-12-11 12:02 ` [PATCH v4] sched/cputime: account ksoftirqd's time on SYSTEM in PREEMPT_RT Tio Zhang
2023-12-15 18:30 ` [PATCH v3] sched/cputime: let ktimers align with ksoftirqd in accounting CPUTIME_SOFTIRQ Yuanhan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130120036.5EpZn4eo@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zyhtheonly@gmail.com \
--cc=zyhtheonly@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®