* [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
@ 2023-11-30 14:32 Andy Shevchenko
2023-11-30 14:44 ` Heikki Krogerus
2023-12-01 11:32 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-11-30 14:32 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel; +Cc: Lee Jones, Heikki Krogerus
The pci_alloc_irq_vectors() returns a positive number on success.
Hence we have to filter the negative numbers for error condition.
Update the check accordingly.
Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 8f5e10817a9c..4621d3950b8f 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
return ret;
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
- if (ret)
+ if (ret < 0)
return ret;
info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
2023-11-30 14:32 [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors() Andy Shevchenko
@ 2023-11-30 14:44 ` Heikki Krogerus
2023-12-01 11:32 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2023-11-30 14:44 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel, Lee Jones
On Thu, Nov 30, 2023 at 04:32:06PM +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
>
> Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
> Reported-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thanks for the quick fix.
Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/mfd/intel-lpss-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 8f5e10817a9c..4621d3950b8f 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
> return ret;
>
> ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> - if (ret)
> + if (ret < 0)
> return ret;
>
> info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: (subset) [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
2023-11-30 14:32 [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors() Andy Shevchenko
2023-11-30 14:44 ` Heikki Krogerus
@ 2023-12-01 11:32 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-12-01 11:32 UTC (permalink / raw)
To: linux-kernel, Andy Shevchenko; +Cc: Lee Jones, Heikki Krogerus
On Thu, 30 Nov 2023 16:32:06 +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
>
>
Applied, thanks!
[1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
commit: d1432c3fc6c1d6a3fe9ab20332ac01336ee98371
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-01 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-30 14:32 [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors() Andy Shevchenko
2023-11-30 14:44 ` Heikki Krogerus
2023-12-01 11:32 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®