mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Nikolay Borisov <nik.borisov@suse.com>
Subject: Re: [PATCH] x86/ia32: State that IA32 emulation is disabled
Date: Thu, 30 Nov 2023 17:09:03 +0100	[thread overview]
Message-ID: <20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local> (raw)
In-Reply-To: <20231130155213.1407-1-bp@alien8.de>

On Thu, Nov 30, 2023 at 04:52:13PM +0100, Borislav Petkov wrote:
> +static inline bool ia32_enabled_verbose(void)
> +{
> +#ifdef CONFIG_IA32_EMULATION
> +	pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
> +#endif
> +	return ia32_enabled();
> +}

As Nik rightfully points out offlist, this should rather be something
like:

---
	bool enabled = ia32_enabled();

#ifdef CONFIG_IA32_EMULATION
	if (!enabled)
		pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
#endif

	return enabled;
---

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  parent reply	other threads:[~2023-11-30 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 15:52 Borislav Petkov
2023-11-30 15:59 ` Nikolay Borisov
2023-11-30 16:00 ` Nikolay Borisov
2023-11-30 16:03   ` Borislav Petkov
2023-11-30 16:04 ` Nikolay Borisov
2023-11-30 16:09 ` Borislav Petkov [this message]
2023-11-30 16:42   ` Brian Gerst
2023-11-30 16:47     ` Brian Gerst
2023-12-06 17:20   ` [PATCH -v2] " Borislav Petkov
2023-12-08 18:42     ` Nikolay Borisov
2023-12-08 19:22       ` Borislav Petkov
2023-12-08 19:28         ` Nikolay Borisov
2023-12-11  9:28 ` [tip: x86/misc] " tip-bot2 for Borislav Petkov (AMD)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130160903.GJZWizn+dPaaViFVKN@fat_crate.local \
    --to=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nik.borisov@suse.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®