From: Nikolay Borisov <nik.borisov@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v2] x86/ia32: State that IA32 emulation is disabled
Date: Fri, 8 Dec 2023 21:28:13 +0200 [thread overview]
Message-ID: <8af70f29-0853-42bc-aabd-338eda6ed154@suse.com> (raw)
In-Reply-To: <20231208192254.GCZXNtDjT73Z4L06h/@fat_crate.local>
On 8.12.23 г. 21:22 ч., Borislav Petkov wrote:
> On Fri, Dec 08, 2023 at 08:42:29PM +0200, Nikolay Borisov wrote:
>>> +static inline bool ia32_enabled_verbose(void)
>>> +{
>>> + bool enabled = ia32_enabled();
>>> +
>>> + if (IS_ENABLED(CONFIG_IA32_EMULATION) && !enabled)
>>
>> nit: But why check config_ia32_emulation explicitly, its state should
>> already be accounted for in ia32_enabled's value? So this check can simply
>> be 'if (!enabled)'
>>
>>> + pr_notice_once("32-bit emulation disabled. You can reenable with ia32_emulation=on\n");
> ^^^^^^^^^^
>
> If CONFIG_IA32_EMULATION is disabled, is there any 32-bit emulation to
> be enabled, at all?
>
Ah, the !enabled condition will then trigger so it will result in a
false print. Fair enough...
next prev parent reply other threads:[~2023-12-08 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 15:52 [PATCH] " Borislav Petkov
2023-11-30 15:59 ` Nikolay Borisov
2023-11-30 16:00 ` Nikolay Borisov
2023-11-30 16:03 ` Borislav Petkov
2023-11-30 16:04 ` Nikolay Borisov
2023-11-30 16:09 ` Borislav Petkov
2023-11-30 16:42 ` Brian Gerst
2023-11-30 16:47 ` Brian Gerst
2023-12-06 17:20 ` [PATCH -v2] " Borislav Petkov
2023-12-08 18:42 ` Nikolay Borisov
2023-12-08 19:22 ` Borislav Petkov
2023-12-08 19:28 ` Nikolay Borisov [this message]
2023-12-11 9:28 ` [tip: x86/misc] " tip-bot2 for Borislav Petkov (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af70f29-0853-42bc-aabd-338eda6ed154@suse.com \
--to=nik.borisov@suse.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®