* [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp
@ 2023-11-30 19:21 Rob Clark
2023-11-30 21:24 ` Steev Klimaszewski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Clark @ 2023-11-30 19:21 UTC (permalink / raw)
To: dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Steev Klimaszewski,
Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Danylo Piliaiev,
open list
From: Rob Clark <robdclark@chromium.org>
The UBWC settings need to match between the display and GPU. When we
updated the GPU settings, we forgot to make the corresponding update on
the display side.
Reported-by: Steev Klimaszewski <steev@kali.org>
Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_mdss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 6865db1e3ce8..29bb38f0bb2c 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -545,7 +545,7 @@ static const struct msm_mdss_data sc8280xp_data = {
.ubwc_dec_version = UBWC_4_0,
.ubwc_swizzle = 6,
.ubwc_static = 1,
- .highest_bank_bit = 2,
+ .highest_bank_bit = 3,
.macrotile_mode = 1,
};
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp
2023-11-30 19:21 [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp Rob Clark
@ 2023-11-30 21:24 ` Steev Klimaszewski
2023-11-30 21:25 ` [Freedreno] " Abhinav Kumar
2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Steev Klimaszewski @ 2023-11-30 21:24 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, freedreno, linux-arm-msm, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Danylo Piliaiev, open list
On Thu, Nov 30, 2023 at 1:21 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
> Reported-by: Steev Klimaszewski <steev@kali.org>
> Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> index 6865db1e3ce8..29bb38f0bb2c 100644
> --- a/drivers/gpu/drm/msm/msm_mdss.c
> +++ b/drivers/gpu/drm/msm/msm_mdss.c
> @@ -545,7 +545,7 @@ static const struct msm_mdss_data sc8280xp_data = {
> .ubwc_dec_version = UBWC_4_0,
> .ubwc_swizzle = 6,
> .ubwc_static = 1,
> - .highest_bank_bit = 2,
> + .highest_bank_bit = 3,
> .macrotile_mode = 1,
> };
>
> --
> 2.42.0
>
Tested on Lenovo Thinkpad X13s
Tested-by: Steev Klimaszewski <steev@kali.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Freedreno] [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp
2023-11-30 19:21 [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp Rob Clark
2023-11-30 21:24 ` Steev Klimaszewski
@ 2023-11-30 21:25 ` Abhinav Kumar
2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2023-11-30 21:25 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, linux-arm-msm, Steev Klimaszewski, Danylo Piliaiev,
Sean Paul, Daniel Vetter, Dmitry Baryshkov, Marijn Suijten,
David Airlie, freedreno, open list
On 11/30/2023 11:21 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
> Reported-by: Steev Klimaszewski <steev@kali.org>
> Fixes: 07e6de738aa6 ("drm/msm/a690: Fix reg values for a690")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp
2023-11-30 19:21 [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp Rob Clark
2023-11-30 21:24 ` Steev Klimaszewski
2023-11-30 21:25 ` [Freedreno] " Abhinav Kumar
@ 2023-12-03 11:26 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-12-03 11:26 UTC (permalink / raw)
To: dri-devel, Rob Clark
Cc: freedreno, linux-arm-msm, Rob Clark, Steev Klimaszewski,
Abhinav Kumar, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Danylo Piliaiev, linux-kernel
On Thu, 30 Nov 2023 11:21:18 -0800, Rob Clark wrote:
> The UBWC settings need to match between the display and GPU. When we
> updated the GPU settings, we forgot to make the corresponding update on
> the display side.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: Correct UBWC settings for sc8280xp
https://gitlab.freedesktop.org/lumag/msm/-/commit/0b414c731432
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-03 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-30 19:21 [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp Rob Clark
2023-11-30 21:24 ` Steev Klimaszewski
2023-11-30 21:25 ` [Freedreno] " Abhinav Kumar
2023-12-03 11:26 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®