From: Jialu Xu <xujialu@vimux.org>
To: nathan@kernel.org, ndesaulniers@google.com, morbo@google.com,
justinstitt@google.com
Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
Jialu Xu <xujialu@vimux.org>
Subject: [PATCH] gen_compile_commands.py: fix path resolve with symlinks in it
Date: Mon, 4 Dec 2023 18:41:42 +0800 [thread overview]
Message-ID: <20231204104141.3618547-1-xujialu@vimux.org> (raw)
When symbolic links are involved in the path, os.path.abspath might not
resolve the symlinks and instead return the absolute path with the
symlinks intact.
use pathlib.Path resolve() instead of os.path.abspath()
Signed-off-by: Jialu Xu <xujialu@vimux.org>
---
scripts/clang-tools/gen_compile_commands.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
index 180952fb91c1b..0a6c0996b4a8f 100755
--- a/scripts/clang-tools/gen_compile_commands.py
+++ b/scripts/clang-tools/gen_compile_commands.py
@@ -11,6 +11,7 @@ import argparse
import json
import logging
import os
+from pathlib import Path
import re
import subprocess
import sys
@@ -172,8 +173,8 @@ def process_line(root_directory, command_prefix, file_path):
# by Make, so this code replaces the escaped version with '#'.
prefix = command_prefix.replace('\#', '#').replace('$(pound)', '#')
- # Use os.path.abspath() to normalize the path resolving '.' and '..' .
- abs_path = os.path.abspath(os.path.join(root_directory, file_path))
+ # Make the path absolute, resolving all symlinks on the way and also normalizing it.
+ abs_path = str(Path(os.path.join(root_directory, file_path)).resolve())
if not os.path.exists(abs_path):
raise ValueError('File %s not found' % abs_path)
return {
--
2.39.2
next reply other threads:[~2023-12-04 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 10:41 Jialu Xu [this message]
2023-12-04 16:59 ` Nathan Chancellor
2023-12-05 2:15 ` Jialu Xu
2023-12-05 2:15 ` [PATCH v2] gen_compile_commands.py: fix path resolve with symlinks in it Jialu Xu
2023-12-05 16:56 ` Nathan Chancellor
2023-12-06 1:20 ` Jialu Xu
2023-12-06 1:20 ` [PATCH v3] " Jialu Xu
2023-12-06 1:24 ` [PATCH v4] " Jialu Xu
2023-12-07 22:54 ` Justin Stitt
2023-12-10 5:52 ` Masahiro Yamada
2023-12-10 7:05 ` Jialu Xu
2023-12-10 7:05 ` [PATCH v5] " Jialu Xu
2023-12-11 17:53 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204104141.3618547-1-xujialu@vimux.org \
--to=xujialu@vimux.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®