From: Jialu Xu <xujialu@vimux.org>
To: masahiroy@kernel.org
Cc: justinstitt@google.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
morbo@google.com, nathan@kernel.org, ndesaulniers@google.com,
xujialu@vimux.org
Subject: Re: [PATCH v4] gen_compile_commands.py: fix path resolve with symlinks in it
Date: Sun, 10 Dec 2023 15:05:32 +0800 [thread overview]
Message-ID: <20231210070533.925534-1-xujialu@vimux.org> (raw)
In-Reply-To: <CAK7LNAQAAZXV3i1sM0ZTFDC3eOaDWBVzOV9FmiLUM5YoX=89Wg@mail.gmail.com>
>Is there any reason why you didn't simply replace
>os.path.abspath() with os.path.realpath() ?
I have tried it before, but obviously, I made a mistake.
>This patch uses pathlib.Path() just in one place,
>leaving many call-sites of os.path.*() functions.
>
>If it is just a matter of your preference,
>you need to convert os.path.*() for consistency
>(as a follow-up patch).
Keep os.path.* as os.path.realpath() works.
>I see one more os.path.abspath()
>
> return (args.log_level,
> os.path.abspath(args.directory),
> args.output,
> args.ar,
> args.paths if len(args.paths) > 0 else [args.directory])
>
>Does it cause a similar issue for the 'directory' field
>with symbolic link jungles?
Yes, also fixed.
--
Best Regards
Jialu Xu
next prev parent reply other threads:[~2023-12-10 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 10:41 [PATCH] " Jialu Xu
2023-12-04 16:59 ` Nathan Chancellor
2023-12-05 2:15 ` Jialu Xu
2023-12-05 2:15 ` [PATCH v2] gen_compile_commands.py: fix path resolve with symlinks in it Jialu Xu
2023-12-05 16:56 ` Nathan Chancellor
2023-12-06 1:20 ` Jialu Xu
2023-12-06 1:20 ` [PATCH v3] " Jialu Xu
2023-12-06 1:24 ` [PATCH v4] " Jialu Xu
2023-12-07 22:54 ` Justin Stitt
2023-12-10 5:52 ` Masahiro Yamada
2023-12-10 7:05 ` Jialu Xu [this message]
2023-12-10 7:05 ` [PATCH v5] " Jialu Xu
2023-12-11 17:53 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231210070533.925534-1-xujialu@vimux.org \
--to=xujialu@vimux.org \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®