* [V2, 1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0
@ 2023-12-08 21:02 Kamal Dasu
2023-12-09 7:52 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Kamal Dasu @ 2023-12-08 21:02 UTC (permalink / raw)
To: ulf.hansson, linux-kernel, alcooperx, linux-arm-kernel,
adrian.hunter, linux-mmc, robh+dt, krzysztof.kozlowski+dt,
conor+dt, devicetree
Cc: f.fainelli, bcm-kernel-feedback-list, Kamal Dasu
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
From: Kamal Dasu <kdasu@broadcom.com>
With newer sdio controller core used for 74165b0 we need to update
the compatibility with "brcm,bcm74165b0-sdhci".
Signed-off-by: Kamal Dasu <kdasu@broadcom.com>
---
Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
index c028039bc477..178d47ed65ca 100644
--- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
+++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
@@ -13,6 +13,10 @@ maintainers:
properties:
compatible:
oneOf:
+ - items:
+ - enum:
+ - brcm,bcm74165b0-sdhci
+ - const: brcm,sdhci-brcmstb
- items:
- enum:
- brcm,bcm7216-sdhci
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4203 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [V2, 1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0
2023-12-08 21:02 [V2, 1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0 Kamal Dasu
@ 2023-12-09 7:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-09 7:52 UTC (permalink / raw)
To: Kamal Dasu, ulf.hansson, linux-kernel, alcooperx,
linux-arm-kernel, adrian.hunter, linux-mmc, robh+dt,
krzysztof.kozlowski+dt, conor+dt, devicetree
Cc: f.fainelli, bcm-kernel-feedback-list, Kamal Dasu
On 08/12/2023 22:02, Kamal Dasu wrote:
> From: Kamal Dasu <kdasu@broadcom.com>
>
> With newer sdio controller core used for 74165b0 we need to update
> the compatibility with "brcm,bcm74165b0-sdhci".
>
> Signed-off-by: Kamal Dasu <kdasu@broadcom.com>
> ---
> Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> index c028039bc477..178d47ed65ca 100644
> --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml
> @@ -13,6 +13,10 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - items:
> + - enum:
> + - brcm,bcm74165b0-sdhci
If this is enum, then it should be combined with other enums like that.
Someone already duplicated this once, so don't make it third time. One
enum for all your variants with the same fallback.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-09 7:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-08 21:02 [V2, 1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0 Kamal Dasu
2023-12-09 7:52 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®