From: "Neeraj Upadhyay (AMD)" <neeraj.iitr10@gmail.com>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, paulmck@kernel.org, Neeraj.Upadhyay@amd.com,
Frederic Weisbecker <frederic@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Neeraj Upadhyay <neeraj.iitr10@gmail.com>
Subject: [PATCH rcu 3/3] srcu: Explain why callbacks invocations can't run concurrently
Date: Tue, 12 Dec 2023 23:18:17 +0530 [thread overview]
Message-ID: <20231212174817.11919-3-neeraj.iitr10@gmail.com> (raw)
In-Reply-To: <20231212174750.GA11886@neeraj.linux>
From: Frederic Weisbecker <frederic@kernel.org>
If an SRCU barrier is queued while callbacks are running and a new
callbacks invocator for the same sdp were to run concurrently, the
RCU barrier might execute too early. As this requirement is non-obvious,
make sure to keep a record.
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Neeraj Upadhyay (AMD) <neeraj.iitr10@gmail.com>
---
kernel/rcu/srcutree.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
index 2bfc8ed1eed2..0351a4e83529 100644
--- a/kernel/rcu/srcutree.c
+++ b/kernel/rcu/srcutree.c
@@ -1715,6 +1715,11 @@ static void srcu_invoke_callbacks(struct work_struct *work)
WARN_ON_ONCE(!rcu_segcblist_segempty(&sdp->srcu_cblist, RCU_NEXT_TAIL));
rcu_segcblist_advance(&sdp->srcu_cblist,
rcu_seq_current(&ssp->srcu_sup->srcu_gp_seq));
+ /*
+ * Although this function is theoretically re-entrant, concurrent
+ * callbacks invocation is disallowed to avoid executing an SRCU barrier
+ * too early.
+ */
if (sdp->srcu_cblist_invoking ||
!rcu_segcblist_ready_cbs(&sdp->srcu_cblist)) {
spin_unlock_irq_rcu_node(sdp);
@@ -1745,6 +1750,7 @@ static void srcu_invoke_callbacks(struct work_struct *work)
sdp->srcu_cblist_invoking = false;
more = rcu_segcblist_ready_cbs(&sdp->srcu_cblist);
spin_unlock_irq_rcu_node(sdp);
+ /* An SRCU barrier or callbacks from previous nesting work pending */
if (more)
srcu_schedule_cbs_sdp(sdp, 0);
}
--
2.40.1
next prev parent reply other threads:[~2023-12-12 17:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 17:47 [PATCH rcu 0/3] SRCU updates for v6.8 Neeraj Upadhyay (AMD)
2023-12-12 17:48 ` [PATCH rcu 1/3] srcu: Remove superfluous callbacks advancing from srcu_gp_start() Neeraj Upadhyay (AMD)
2023-12-12 17:48 ` [PATCH rcu 2/3] srcu: No need to advance/accelerate if no callback enqueued Neeraj Upadhyay (AMD)
2023-12-12 17:48 ` Neeraj Upadhyay (AMD) [this message]
2023-12-13 14:27 ` [PATCH rcu 3/3] srcu: Explain why callbacks invocations can't run concurrently Joel Fernandes
2023-12-13 17:52 ` Paul E. McKenney
2023-12-13 18:35 ` Joel Fernandes
2023-12-13 18:55 ` Paul E. McKenney
2023-12-13 19:01 ` Joel Fernandes
2023-12-13 18:18 ` [PATCH rcu 4/3] srcu: Use try-lock lockdep annotation for NMI-safe access Neeraj Upadhyay (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212174817.11919-3-neeraj.iitr10@gmail.com \
--to=neeraj.iitr10@gmail.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®