mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpiolib: cleanup for duplicated including
@ 2023-12-15  8:46 Wang Jinchao
  2023-12-15 15:47 ` Andy Shevchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Wang Jinchao @ 2023-12-15  8:46 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, linux-gpio,
	linux-kernel
  Cc: stone.xulei, wangjinchao

rm second `#include <linux/err.h>`

Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
 include/linux/gpio/driver.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 0aed62f0c633..d659ba63bc20 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -789,8 +789,6 @@ int gpio_device_get_base(struct gpio_device *gdev);
 
 #else /* CONFIG_GPIOLIB */
 
-#include <linux/err.h>
-
 #include <asm/bug.h>
 
 static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
-- 
2.40.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpiolib: cleanup for duplicated including
  2023-12-15  8:46 [PATCH] gpiolib: cleanup for duplicated including Wang Jinchao
@ 2023-12-15 15:47 ` Andy Shevchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2023-12-15 15:47 UTC (permalink / raw)
  To: Wang Jinchao
  Cc: Linus Walleij, Bartosz Golaszewski, linux-gpio, linux-kernel,
	stone.xulei

On Fri, Dec 15, 2023 at 04:46:04PM +0800, Wang Jinchao wrote:
> rm second `#include <linux/err.h>`

rm --> Remove

Missing period at the end of the sentence.

Please, drop also asm/errno.h as they are guaranteed by the global err.h
inclusion.

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-15 15:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-15  8:46 [PATCH] gpiolib: cleanup for duplicated including Wang Jinchao
2023-12-15 15:47 ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®