* [PATCH] fs: remove duplicated including of posix_acl.h
@ 2023-12-15 10:17 Wang Jinchao
2023-12-15 11:16 ` Amir Goldstein
0 siblings, 1 reply; 2+ messages in thread
From: Wang Jinchao @ 2023-12-15 10:17 UTC (permalink / raw)
To: Miklos Szeredi, Amir Goldstein, linux-unionfs, linux-kernel
Cc: stone.xulei, wangjinchao
remove the second including of linux/posix_acl.h
Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
fs/overlayfs/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index c63b31a460be..2003425875d9 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -14,7 +14,6 @@
#include <linux/fileattr.h>
#include <linux/security.h>
#include <linux/namei.h>
-#include <linux/posix_acl.h>
#include <linux/posix_acl_xattr.h>
#include "overlayfs.h"
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: remove duplicated including of posix_acl.h
2023-12-15 10:17 [PATCH] fs: remove duplicated including of posix_acl.h Wang Jinchao
@ 2023-12-15 11:16 ` Amir Goldstein
0 siblings, 0 replies; 2+ messages in thread
From: Amir Goldstein @ 2023-12-15 11:16 UTC (permalink / raw)
To: Wang Jinchao; +Cc: Miklos Szeredi, linux-unionfs, linux-kernel, stone.xulei
On Fri, Dec 15, 2023 at 12:17 PM Wang Jinchao <wangjinchao@xfusion.com> wrote:
>
> remove the second including of linux/posix_acl.h
>
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
> fs/overlayfs/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index c63b31a460be..2003425875d9 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -14,7 +14,6 @@
> #include <linux/fileattr.h>
> #include <linux/security.h>
> #include <linux/namei.h>
> -#include <linux/posix_acl.h>
> #include <linux/posix_acl_xattr.h>
> #include "overlayfs.h"
>
Since both posix_acl.h and posix_acl_xattr.h are included by overlayfs.h
I would rather remove them both including the first posix_acl.h include.
It is far from being the only duplicate include in "overlayfs.h" and it is not
important enough IMO to start a cleanup project, but if you are going to
tidy up includes for a particular file, I'd rather use the opportunity to
cleanup that duplicity as well.
Thanks,
Amir.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-15 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-15 10:17 [PATCH] fs: remove duplicated including of posix_acl.h Wang Jinchao
2023-12-15 11:16 ` Amir Goldstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®