* [PATCH] x86/boot: remove redundant initialization of variable delta
@ 2023-12-19 14:13 Colin Ian King
2023-12-20 21:32 ` [tip: x86/boot] x86/boot: Remove redundant initialization of the 'delta' variable in strcmp() tip-bot2 for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-12-19 14:13 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H . Peter Anvin
Cc: kernel-janitors, linux-kernel
The variable delta is being initialized with a value that is never
read. The assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
arch/x86/boot/string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index 1c8541ae3b3a..c23f3b9c84fe 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -49,7 +49,7 @@ int strcmp(const char *str1, const char *str2)
{
const unsigned char *s1 = (const unsigned char *)str1;
const unsigned char *s2 = (const unsigned char *)str2;
- int delta = 0;
+ int delta;
while (*s1 || *s2) {
delta = *s1 - *s2;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [tip: x86/boot] x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()
2023-12-19 14:13 [PATCH] x86/boot: remove redundant initialization of variable delta Colin Ian King
@ 2023-12-20 21:32 ` tip-bot2 for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Colin Ian King @ 2023-12-20 21:32 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Colin Ian King, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the x86/boot branch of tip:
Commit-ID: 257ca14f4d780e27a0605fd68053d2cc3178a232
Gitweb: https://git.kernel.org/tip/257ca14f4d780e27a0605fd68053d2cc3178a232
Author: Colin Ian King <colin.i.king@gmail.com>
AuthorDate: Tue, 19 Dec 2023 14:13:04
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 20 Dec 2023 22:23:33 +01:00
x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()
The 'delta' variable is zero-initialized, but never
read before the real initialization happens.
The assignment is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231219141304.367200-1-colin.i.king@gmail.com
---
arch/x86/boot/string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index 1c8541a..c23f3b9 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -49,7 +49,7 @@ int strcmp(const char *str1, const char *str2)
{
const unsigned char *s1 = (const unsigned char *)str1;
const unsigned char *s2 = (const unsigned char *)str2;
- int delta = 0;
+ int delta;
while (*s1 || *s2) {
delta = *s1 - *s2;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-20 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-19 14:13 [PATCH] x86/boot: remove redundant initialization of variable delta Colin Ian King
2023-12-20 21:32 ` [tip: x86/boot] x86/boot: Remove redundant initialization of the 'delta' variable in strcmp() tip-bot2 for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®