* [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table
@ 2023-12-20 18:47 Sam Protsenko
2023-12-20 19:02 ` Andy Shevchenko
2023-12-20 19:07 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Sam Protsenko @ 2023-12-20 18:47 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lars-Peter Clausen, Andy Shevchenko, Angel Iglesias,
Linus Walleij, Akinobu Mita, linux-iio, linux-kernel
"bmp085" is missing in bmp280_spi_id[] table, which leads to the next
warning in dmesg:
SPI driver bmp280 has no spi_device_id for bosch,bmp085
Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
bmp280_of_spi_match[] table to fix the above warning.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
---
drivers/iio/pressure/bmp280-spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
index 433d6fac83c4..e8a5fed07e88 100644
--- a/drivers/iio/pressure/bmp280-spi.c
+++ b/drivers/iio/pressure/bmp280-spi.c
@@ -87,6 +87,7 @@ static const struct of_device_id bmp280_of_spi_match[] = {
MODULE_DEVICE_TABLE(of, bmp280_of_spi_match);
static const struct spi_device_id bmp280_spi_id[] = {
+ { "bmp085", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp180", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp181", (kernel_ulong_t)&bmp180_chip_info },
{ "bmp280", (kernel_ulong_t)&bmp280_chip_info },
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table
2023-12-20 18:47 [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table Sam Protsenko
@ 2023-12-20 19:02 ` Andy Shevchenko
2023-12-20 19:07 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-12-20 19:02 UTC (permalink / raw)
To: Sam Protsenko
Cc: Jonathan Cameron, Lars-Peter Clausen, Angel Iglesias,
Linus Walleij, Akinobu Mita, linux-iio, linux-kernel
On Wed, Dec 20, 2023 at 12:47:53PM -0600, Sam Protsenko wrote:
> "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> warning in dmesg:
>
> SPI driver bmp280 has no spi_device_id for bosch,bmp085
>
> Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> bmp280_of_spi_match[] table to fix the above warning.
Good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table
2023-12-20 18:47 [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table Sam Protsenko
2023-12-20 19:02 ` Andy Shevchenko
@ 2023-12-20 19:07 ` Linus Walleij
2023-12-21 17:09 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2023-12-20 19:07 UTC (permalink / raw)
To: Sam Protsenko
Cc: Jonathan Cameron, Lars-Peter Clausen, Andy Shevchenko,
Angel Iglesias, Akinobu Mita, linux-iio, linux-kernel
On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
> "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> warning in dmesg:
>
> SPI driver bmp280 has no spi_device_id for bosch,bmp085
>
> Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> bmp280_of_spi_match[] table to fix the above warning.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
Right! Thanks for fixing this Sam!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table
2023-12-20 19:07 ` Linus Walleij
@ 2023-12-21 17:09 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-12-21 17:09 UTC (permalink / raw)
To: Linus Walleij
Cc: Sam Protsenko, Lars-Peter Clausen, Andy Shevchenko,
Angel Iglesias, Akinobu Mita, linux-iio, linux-kernel
On Wed, 20 Dec 2023 20:07:57 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko
> <semen.protsenko@linaro.org> wrote:
>
> > "bmp085" is missing in bmp280_spi_id[] table, which leads to the next
> > warning in dmesg:
> >
> > SPI driver bmp280 has no spi_device_id for bosch,bmp085
> >
> > Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in
> > bmp280_of_spi_match[] table to fix the above warning.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver")
>
> Right! Thanks for fixing this Sam!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
J
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 17:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 18:47 [PATCH] iio: pressure: bmp280: Add missing bmp085 to SPI id table Sam Protsenko
2023-12-20 19:02 ` Andy Shevchenko
2023-12-20 19:07 ` Linus Walleij
2023-12-21 17:09 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®