* [PATCH v2] LoongArch: signal.c: add header file to fix build error
@ 2023-12-22 4:45 Randy Dunlap
2023-12-22 4:59 ` Huacai Chen
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-12-22 4:45 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Huacai Chen, WANG Xuerui, loongarch, Kent Overstreet
loongarch's signal.c uses rseq_signal_deliver() so it should
pull in the appropriate header to prevent a build error:
../arch/loongarch/kernel/signal.c: In function 'handle_signal':
../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
1034 | rseq_signal_deliver(ksig, regs);
| ^~~~~~~~~~~~~~~~~~~
Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>
Cc: loongarch@lists.linux.dev
Cc: Kent Overstreet <kent.overstreet@gmail.com>
---
v2: repair Cc: list
arch/loongarch/kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
--- a/arch/loongarch/kernel/signal.c
+++ b/arch/loongarch/kernel/signal.c
@@ -15,6 +15,7 @@
#include <linux/context_tracking.h>
#include <linux/entry-common.h>
#include <linux/irqflags.h>
+#include <linux/rseq.h>
#include <linux/sched.h>
#include <linux/mm.h>
#include <linux/personality.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] LoongArch: signal.c: add header file to fix build error
2023-12-22 4:45 [PATCH v2] LoongArch: signal.c: add header file to fix build error Randy Dunlap
@ 2023-12-22 4:59 ` Huacai Chen
2023-12-23 10:27 ` Huacai Chen
0 siblings, 1 reply; 4+ messages in thread
From: Huacai Chen @ 2023-12-22 4:59 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, WANG Xuerui, loongarch, Kent Overstreet
Hi, Randy,
I cannot reproduce it with the default config file.
Huacai
On Fri, Dec 22, 2023 at 12:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> loongarch's signal.c uses rseq_signal_deliver() so it should
> pull in the appropriate header to prevent a build error:
>
> ../arch/loongarch/kernel/signal.c: In function 'handle_signal':
> ../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
> 1034 | rseq_signal_deliver(ksig, regs);
> | ^~~~~~~~~~~~~~~~~~~
>
> Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: WANG Xuerui <kernel@xen0n.name>
> Cc: loongarch@lists.linux.dev
> Cc: Kent Overstreet <kent.overstreet@gmail.com>
> ---
> v2: repair Cc: list
>
> arch/loongarch/kernel/signal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
> --- a/arch/loongarch/kernel/signal.c
> +++ b/arch/loongarch/kernel/signal.c
> @@ -15,6 +15,7 @@
> #include <linux/context_tracking.h>
> #include <linux/entry-common.h>
> #include <linux/irqflags.h>
> +#include <linux/rseq.h>
> #include <linux/sched.h>
> #include <linux/mm.h>
> #include <linux/personality.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] LoongArch: signal.c: add header file to fix build error
2023-12-22 4:59 ` Huacai Chen
@ 2023-12-23 10:27 ` Huacai Chen
2023-12-23 17:16 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Huacai Chen @ 2023-12-23 10:27 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, WANG Xuerui, loongarch, Kent Overstreet
On Fri, Dec 22, 2023 at 12:59 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Hi, Randy,
>
> I cannot reproduce it with the default config file.
Oh, I know, this error only occurs in linux-next, but I think this
patch should be squashed into "rseq: Split out rseq.h from sched.h".
Or as a fix applied to the bcachefs tree rather than the loongarch
tree.
Huacai
>
> Huacai
>
> On Fri, Dec 22, 2023 at 12:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > loongarch's signal.c uses rseq_signal_deliver() so it should
> > pull in the appropriate header to prevent a build error:
> >
> > ../arch/loongarch/kernel/signal.c: In function 'handle_signal':
> > ../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
> > 1034 | rseq_signal_deliver(ksig, regs);
> > | ^~~~~~~~~~~~~~~~~~~
> >
> > Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Huacai Chen <chenhuacai@kernel.org>
> > Cc: WANG Xuerui <kernel@xen0n.name>
> > Cc: loongarch@lists.linux.dev
> > Cc: Kent Overstreet <kent.overstreet@gmail.com>
> > ---
> > v2: repair Cc: list
> >
> > arch/loongarch/kernel/signal.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
> > --- a/arch/loongarch/kernel/signal.c
> > +++ b/arch/loongarch/kernel/signal.c
> > @@ -15,6 +15,7 @@
> > #include <linux/context_tracking.h>
> > #include <linux/entry-common.h>
> > #include <linux/irqflags.h>
> > +#include <linux/rseq.h>
> > #include <linux/sched.h>
> > #include <linux/mm.h>
> > #include <linux/personality.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] LoongArch: signal.c: add header file to fix build error
2023-12-23 10:27 ` Huacai Chen
@ 2023-12-23 17:16 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-12-23 17:16 UTC (permalink / raw)
To: Huacai Chen; +Cc: linux-kernel, WANG Xuerui, loongarch, Kent Overstreet
On 12/23/23 02:27, Huacai Chen wrote:
> On Fri, Dec 22, 2023 at 12:59 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>>
>> Hi, Randy,
>>
>> I cannot reproduce it with the default config file.
> Oh, I know, this error only occurs in linux-next, but I think this
> patch should be squashed into "rseq: Split out rseq.h from sched.h".
> Or as a fix applied to the bcachefs tree rather than the loongarch
> tree.
Yes, I think Kent is taking care of it.
Yes, in linux-next.
Thanks.
> Huacai
>
>>
>> Huacai
>>
>> On Fri, Dec 22, 2023 at 12:46 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> loongarch's signal.c uses rseq_signal_deliver() so it should
>>> pull in the appropriate header to prevent a build error:
>>>
>>> ../arch/loongarch/kernel/signal.c: In function 'handle_signal':
>>> ../arch/loongarch/kernel/signal.c:1034:9: error: implicit declaration of function 'rseq_signal_deliver' [-Werror=implicit-function-declaration]
>>> 1034 | rseq_signal_deliver(ksig, regs);
>>> | ^~~~~~~~~~~~~~~~~~~
>>>
>>> Fixes: b74baf4ad05b ("LoongArch: Add signal handling support")
>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: Huacai Chen <chenhuacai@kernel.org>
>>> Cc: WANG Xuerui <kernel@xen0n.name>
>>> Cc: loongarch@lists.linux.dev
>>> Cc: Kent Overstreet <kent.overstreet@gmail.com>
>>> ---
>>> v2: repair Cc: list
>>>
>>> arch/loongarch/kernel/signal.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff -- a/arch/loongarch/kernel/signal.c b/arch/loongarch/kernel/signal.c
>>> --- a/arch/loongarch/kernel/signal.c
>>> +++ b/arch/loongarch/kernel/signal.c
>>> @@ -15,6 +15,7 @@
>>> #include <linux/context_tracking.h>
>>> #include <linux/entry-common.h>
>>> #include <linux/irqflags.h>
>>> +#include <linux/rseq.h>
>>> #include <linux/sched.h>
>>> #include <linux/mm.h>
>>> #include <linux/personality.h>
--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-23 17:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22 4:45 [PATCH v2] LoongArch: signal.c: add header file to fix build error Randy Dunlap
2023-12-22 4:59 ` Huacai Chen
2023-12-23 10:27 ` Huacai Chen
2023-12-23 17:16 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®