mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* drivers/gpu/drm/nouveau/nouveau_svm.c:829:13: warning: variable 'ret' set but not used
@ 2023-12-25  2:46 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-12-25  2:46 UTC (permalink / raw)
  To: Ralph Campbell; +Cc: oe-kbuild-all, linux-kernel, Ben Skeggs

Hi Ralph,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   861deac3b092f37b2c5e6871732f3e11486f7082
commit: e3d8b08904694e9ccae5163d0bb7d35fa66e5bdc drm/nouveau/svm: map pages after migration
date:   3 years, 7 months ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231225/202312251018.JVE0C0kT-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231225/202312251018.JVE0C0kT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312251018.JVE0C0kT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_pfns_map':
>> drivers/gpu/drm/nouveau/nouveau_svm.c:829:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     829 |         int ret;
         |             ^~~


vim +/ret +829 drivers/gpu/drm/nouveau/nouveau_svm.c

   823	
   824	void
   825	nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm,
   826			 unsigned long addr, u64 *pfns, unsigned long npages)
   827	{
   828		struct nouveau_pfnmap_args *args = nouveau_pfns_to_args(pfns);
 > 829		int ret;
   830	
   831		args->p.addr = addr;
   832		args->p.size = npages << PAGE_SHIFT;
   833	
   834		mutex_lock(&svmm->mutex);
   835	
   836		svmm->vmm->vmm.object.client->super = true;
   837		ret = nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) +
   838					npages * sizeof(args->p.phys[0]), NULL);
   839		svmm->vmm->vmm.object.client->super = false;
   840	
   841		mutex_unlock(&svmm->mutex);
   842	}
   843	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* drivers/gpu/drm/nouveau/nouveau_svm.c:829:13: warning: variable 'ret' set but not used
@ 2023-11-06  6:01 kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-11-06  6:01 UTC (permalink / raw)
  To: Ralph Campbell; +Cc: oe-kbuild-all, linux-kernel, Ben Skeggs

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   d2f51b3516dade79269ff45eae2a7668ae711b25
commit: e3d8b08904694e9ccae5163d0bb7d35fa66e5bdc drm/nouveau/svm: map pages after migration
date:   3 years, 6 months ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231106/202311061339.WUjbKLrr-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231106/202311061339.WUjbKLrr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311061339.WUjbKLrr-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/nouveau/nouveau_svm.c: In function 'nouveau_pfns_map':
>> drivers/gpu/drm/nouveau/nouveau_svm.c:829:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     829 |         int ret;
         |             ^~~


vim +/ret +829 drivers/gpu/drm/nouveau/nouveau_svm.c

   823	
   824	void
   825	nouveau_pfns_map(struct nouveau_svmm *svmm, struct mm_struct *mm,
   826			 unsigned long addr, u64 *pfns, unsigned long npages)
   827	{
   828		struct nouveau_pfnmap_args *args = nouveau_pfns_to_args(pfns);
 > 829		int ret;
   830	
   831		args->p.addr = addr;
   832		args->p.size = npages << PAGE_SHIFT;
   833	
   834		mutex_lock(&svmm->mutex);
   835	
   836		svmm->vmm->vmm.object.client->super = true;
   837		ret = nvif_object_ioctl(&svmm->vmm->vmm.object, args, sizeof(*args) +
   838					npages * sizeof(args->p.phys[0]), NULL);
   839		svmm->vmm->vmm.object.client->super = false;
   840	
   841		mutex_unlock(&svmm->mutex);
   842	}
   843	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-25  2:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-25  2:46 drivers/gpu/drm/nouveau/nouveau_svm.c:829:13: warning: variable 'ret' set but not used kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2023-11-06  6:01 kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®