* [PATCH] drm/msm/a7xx: Fix LLC typo
@ 2024-01-02 19:33 Rob Clark
2024-01-02 20:12 ` Konrad Dybcio
0 siblings, 1 reply; 3+ messages in thread
From: Rob Clark @ 2024-01-02 19:33 UTC (permalink / raw)
To: dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Konrad Dybcio, Akhil P Oommen, Danylo Piliaiev,
Bjorn Andersson, open list
From: Rob Clark <robdclark@chromium.org>
We'd miss actually activating LLC.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index a5660d63535b..54dc5eb37f70 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
msm_devfreq_resume(gpu);
- adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
+ adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);
return ret;
}
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/a7xx: Fix LLC typo
2024-01-02 19:33 [PATCH] drm/msm/a7xx: Fix LLC typo Rob Clark
@ 2024-01-02 20:12 ` Konrad Dybcio
2024-01-03 18:48 ` Rob Clark
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Dybcio @ 2024-01-02 20:12 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Akhil P Oommen, Danylo Piliaiev, Bjorn Andersson,
open list
On 2.01.2024 20:33, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> We'd miss actually activating LLC.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index a5660d63535b..54dc5eb37f70 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
>
> msm_devfreq_resume(gpu);
>
> - adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
> + adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);
/me cleans glasses
oh..
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/a7xx: Fix LLC typo
2024-01-02 20:12 ` Konrad Dybcio
@ 2024-01-03 18:48 ` Rob Clark
0 siblings, 0 replies; 3+ messages in thread
From: Rob Clark @ 2024-01-03 18:48 UTC (permalink / raw)
To: Konrad Dybcio
Cc: dri-devel, freedreno, linux-arm-msm, Rob Clark, Abhinav Kumar,
Dmitry Baryshkov, Sean Paul, Marijn Suijten, David Airlie,
Daniel Vetter, Akhil P Oommen, Danylo Piliaiev, Bjorn Andersson,
open list
On Tue, Jan 2, 2024 at 12:12 PM Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 2.01.2024 20:33, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > We'd miss actually activating LLC.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > index a5660d63535b..54dc5eb37f70 100644
> > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> > @@ -1646,7 +1646,7 @@ static int a6xx_gmu_pm_resume(struct msm_gpu *gpu)
> >
> > msm_devfreq_resume(gpu);
> >
> > - adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate : a6xx_llc_activate(a6xx_gpu);
> > + adreno_is_a7xx(adreno_gpu) ? a7xx_llc_activate(a6xx_gpu) : a6xx_llc_activate(a6xx_gpu);
>
> /me cleans glasses
>
> oh..
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
I suppose I should also add,
Fixes: af66706accdf ("drm/msm/a6xx: Add skeleton A7xx support")
> Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-03 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-02 19:33 [PATCH] drm/msm/a7xx: Fix LLC typo Rob Clark
2024-01-02 20:12 ` Konrad Dybcio
2024-01-03 18:48 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®