mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH ethtool-next 0/3] ethtool: Introduce PHY listing and targetting
@ 2024-01-03 14:29 Maxime Chevallier
  2024-01-03 14:29 ` [PATCH ethtool-next 1/3] update UAPI header copies Maxime Chevallier
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Maxime Chevallier @ 2024-01-03 14:29 UTC (permalink / raw)
  To: davem, Michal Kubecek
  Cc: Maxime Chevallier, netdev, linux-kernel, thomas.petazzoni,
	Andrew Lunn, Jakub Kicinski, Eric Dumazet, Paolo Abeni,
	Russell King, linux-arm-kernel, Christophe Leroy, Herve Codina,
	Florian Fainelli, Heiner Kallweit, Vladimir Oltean,
	Köry Maincent, Jesse Brandeburg, Jonathan Corbet,
	Marek Behún, Piergiorgio Beruto, Oleksij Rempel,
	Nicolò Veronese, Simon Horman

Hello everyone,

This series implements the ethtool part of the multi-PHY support that was
recently merged into net-next :

https://lore.kernel.org/netdev/20231221180047.1924733-1-maxime.chevallier@bootlin.com/

The series starts with a UAPI header copy (I don't really know if it's up
to me to do this, let me know if I should drop it).

The second patch adds the possibility of passing a PHY index for the
PSE-PD, PLCA and Cable-testing commands, in such a manner :

ethtool --phy 2 --cable-test eth0

The new '--phy' parameter is optional for PHY-targetting commands, if it's
not there, we use the old behaviour of relying on the PHY directly attached
to the netdevice to perform the command.

The parameter comes before the actual command to make it generic, after all
the PHY index is passed in the request header.

The Third patch adds a new ethtool option to display the PHYs present on
an interface, along with enough information to reconstruct the link topology.
As it relies on the netlink DUMP messages, some internal helpers were added
in ethtool to send DUMP requests that includes a devname in the header, to
perform a filtered dump. Here are a few examples of what you can expect on
an interface that has 2 PHYs (the 88x3310 PHY exposes an SFP bus, on which
a module that also contains a PHY is plugged)

# ethtool --show-phys eth0

PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
PHY id: 0
Upstream type: MAC

PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
PHY id: 21040322
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0

Here's another example using the wildcard devname, that lists all PHYs on
all interfaces :

# ethtool --show-phys *

PHY for eth0:
PHY index: 1
Driver name: mv88x3310
PHY device name: f212a600.mdio-mii:00
Downstream SFP bus name: sfp-eth0
PHY id: 0
Upstream type: MAC

PHY for eth0:
PHY index: 2
Driver name: Marvell 88E1111
PHY device name: i2c:sfp-eth0:16
PHY id: 21040322
Upstream type: PHY
Upstream PHY index: 1
Upstream SFP name: sfp-eth0

PHY for eth2:
PHY index: 1
Driver name: Marvell 88E1510
PHY device name: f212a200.mdio-mii:00
PHY id: 21040593
Upstream type: MAC

Thanks,

Maxime

Maxime Chevallier (3):
  update UAPI header copies
  ethtool: Allow passing a PHY index for phy-targetting commands
  ethtool: Introduce a command to list PHYs

 Makefile.am                  |   1 +
 ethtool.c                    |  30 +-
 internal.h                   |   1 +
 netlink/cable_test.c         |   4 +-
 netlink/extapi.h             |   1 +
 netlink/msgbuff.c            |  52 +++-
 netlink/msgbuff.h            |   3 +
 netlink/nlsock.c             |  25 ++
 netlink/nlsock.h             |   2 +
 netlink/phy.c                | 139 +++++++++
 netlink/plca.c               |   4 +-
 netlink/pse-pd.c             |   4 +-
 uapi/linux/ethtool.h         |  56 +++-
 uapi/linux/ethtool_netlink.h |  31 ++
 uapi/linux/if_link.h         | 529 +++++++++++++++++++++++++++++++++++
 uapi/linux/stddef.h          |   2 +-
 16 files changed, 851 insertions(+), 33 deletions(-)
 create mode 100644 netlink/phy.c

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH ethtool-next 0/3] Add support for hardware timestamp provider
@ 2025-03-05 17:33 Kory Maincent
  2025-03-05 17:33 ` [PATCH ethtool-next 1/3] update UAPI header copies Kory Maincent
  0 siblings, 1 reply; 6+ messages in thread
From: Kory Maincent @ 2025-03-05 17:33 UTC (permalink / raw)
  To: Michal Kubecek, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Andrew Lunn, Willem de Bruijn, Jason Xing, Russell King
  Cc: netdev, linux-kernel, Thomas Petazzoni, Maxime Chevallier, Kory Maincent

Add support for reading tsinfo of a specific hardware timetstamp provider.
Enable selecting the hwtstamp provider within the network topology of a
network interface.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Kory Maincent (3):
      update UAPI header copies
      tsinfo: Add support for hwtstamp provider
      netlink: Add support for tsconfig command

 Makefile.am                            |   1 +
 ethtool.8.in                           |  41 +-
 ethtool.c                              |  14 +-
 netlink/extapi.h                       |   4 +
 netlink/ts.h                           |  22 +
 netlink/tsconfig.c                     | 153 ++++++
 netlink/tsinfo.c                       | 110 +++-
 uapi/linux/ethtool.h                   |  31 ++
 uapi/linux/ethtool_netlink.h           | 899 +--------------------------------
 uapi/linux/ethtool_netlink_generated.h | 821 ++++++++++++++++++++++++++++++
 uapi/linux/if_link.h                   |  26 +
 uapi/linux/net_tstamp.h                |  11 +
 uapi/linux/rtnetlink.h                 |  22 +-
 uapi/linux/stddef.h                    |  13 +-
 uapi/linux/types.h                     |   1 +
 15 files changed, 1262 insertions(+), 907 deletions(-)
---
base-commit: c62310eb2999e40545d0aa6f3a7489864b633607
change-id: 20241205-feature_ptp-5f11ec7a5b95

Best regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-03-05 17:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-03 14:29 [PATCH ethtool-next 0/3] ethtool: Introduce PHY listing and targetting Maxime Chevallier
2024-01-03 14:29 ` [PATCH ethtool-next 1/3] update UAPI header copies Maxime Chevallier
2024-01-03 14:29 ` [PATCH ethtool-next 2/3] ethtool: Allow passing a PHY index for phy-targetting commands Maxime Chevallier
2024-01-03 14:29 ` [PATCH ethtool-next 3/3] ethtool: Introduce a command to list PHYs Maxime Chevallier
2024-04-17 20:44 ` [PATCH ethtool-next 0/3] ethtool: Introduce PHY listing and targetting Michal Kubecek
2025-03-05 17:33 [PATCH ethtool-next 0/3] Add support for hardware timestamp provider Kory Maincent
2025-03-05 17:33 ` [PATCH ethtool-next 1/3] update UAPI header copies Kory Maincent

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®