* [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc()
@ 2024-01-06 16:27 Erick Archer
2024-01-06 17:28 ` Gustavo A. R. Silva
2024-01-08 7:52 ` Péter Ujfalusi
0 siblings, 2 replies; 3+ messages in thread
From: Erick Archer @ 2024-01-06 16:27 UTC (permalink / raw)
To: Peter Ujfalusi, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Gustavo A. R. Silva
Cc: Erick Archer, alsa-devel, linux-sound, linux-kernel, linux-hardening
Use 2-factor multiplication argument form devm_kcalloc() instead
of devm_kzalloc().
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
---
sound/soc/ti/j721e-evm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c
index b4b158dc736e..d9d1e021f5b2 100644
--- a/sound/soc/ti/j721e-evm.c
+++ b/sound/soc/ti/j721e-evm.c
@@ -649,7 +649,7 @@ static int j721e_soc_probe_cpb(struct j721e_priv *priv, int *link_idx,
* Link 2: McASP10 <- pcm3168a_1 ADC
*/
comp_count = 6;
- compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
+ compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
GFP_KERNEL);
if (!compnent) {
ret = -ENOMEM;
@@ -763,7 +763,7 @@ static int j721e_soc_probe_ivi(struct j721e_priv *priv, int *link_idx,
* \ pcm3168a_b ADC
*/
comp_count = 8;
- compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
+ compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
GFP_KERNEL);
if (!compnent) {
ret = -ENOMEM;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc()
2024-01-06 16:27 [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc() Erick Archer
@ 2024-01-06 17:28 ` Gustavo A. R. Silva
2024-01-08 7:52 ` Péter Ujfalusi
1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2024-01-06 17:28 UTC (permalink / raw)
To: Erick Archer, Peter Ujfalusi, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Gustavo A. R. Silva
Cc: alsa-devel, linux-sound, linux-kernel, linux-hardening
On 1/6/24 10:27, Erick Archer wrote:
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
>
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
--
Gustavo
> ---
> sound/soc/ti/j721e-evm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c
> index b4b158dc736e..d9d1e021f5b2 100644
> --- a/sound/soc/ti/j721e-evm.c
> +++ b/sound/soc/ti/j721e-evm.c
> @@ -649,7 +649,7 @@ static int j721e_soc_probe_cpb(struct j721e_priv *priv, int *link_idx,
> * Link 2: McASP10 <- pcm3168a_1 ADC
> */
> comp_count = 6;
> - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
> + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
> GFP_KERNEL);
> if (!compnent) {
> ret = -ENOMEM;
> @@ -763,7 +763,7 @@ static int j721e_soc_probe_ivi(struct j721e_priv *priv, int *link_idx,
> * \ pcm3168a_b ADC
> */
> comp_count = 8;
> - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
> + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
> GFP_KERNEL);
> if (!compnent) {
> ret = -ENOMEM;
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc()
2024-01-06 16:27 [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc() Erick Archer
2024-01-06 17:28 ` Gustavo A. R. Silva
@ 2024-01-08 7:52 ` Péter Ujfalusi
1 sibling, 0 replies; 3+ messages in thread
From: Péter Ujfalusi @ 2024-01-08 7:52 UTC (permalink / raw)
To: Erick Archer, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Gustavo A. R. Silva
Cc: alsa-devel, linux-sound, linux-kernel, linux-hardening
On 06/01/2024 18:27, Erick Archer wrote:
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
>
> Link: https://github.com/KSPP/linux/issues/162
> Signed-off-by: Erick Archer <erick.archer@gmx.com>
Can you fix the commit title to:
ASoC: ti: j721e-evm.: Use devm_kcalloc() instead of devm_kzalloc()
and send v2 with my:
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> ---
> sound/soc/ti/j721e-evm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/ti/j721e-evm.c b/sound/soc/ti/j721e-evm.c
> index b4b158dc736e..d9d1e021f5b2 100644
> --- a/sound/soc/ti/j721e-evm.c
> +++ b/sound/soc/ti/j721e-evm.c
> @@ -649,7 +649,7 @@ static int j721e_soc_probe_cpb(struct j721e_priv *priv, int *link_idx,
> * Link 2: McASP10 <- pcm3168a_1 ADC
> */
> comp_count = 6;
> - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
> + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
> GFP_KERNEL);
> if (!compnent) {
> ret = -ENOMEM;
> @@ -763,7 +763,7 @@ static int j721e_soc_probe_ivi(struct j721e_priv *priv, int *link_idx,
> * \ pcm3168a_b ADC
> */
> comp_count = 8;
> - compnent = devm_kzalloc(priv->dev, comp_count * sizeof(*compnent),
> + compnent = devm_kcalloc(priv->dev, comp_count, sizeof(*compnent),
> GFP_KERNEL);
> if (!compnent) {
> ret = -ENOMEM;
> --
> 2.25.1
>
--
Péter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-08 7:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-06 16:27 [PATCH] ASoC: ti: Use devm_kcalloc() instead of devm_kzalloc() Erick Archer
2024-01-06 17:28 ` Gustavo A. R. Silva
2024-01-08 7:52 ` Péter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®