* [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section
@ 2024-01-08 14:08 Lukas Bulwahn
2024-01-08 16:01 ` Carlos Bilbao
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2024-01-08 14:08 UTC (permalink / raw)
To: Elena Reshetova, Carlos Bilbao, Jonathan Corbet, linux-doc
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
threat model for x86 virtualization") adds new documentation and a
corresponding MAINTAINERS section. It however uses spaces instead of a
single tab for all the entries in that MAINTAINERS section.
Although, the get_maintainer.pl script handles spaces instead of tabs
silently, the MAINTAINERS will quickly get into a messy state with
different indentations throughout the file. So, the checkpatch.pl script
complains when spaces instead of a single tab are used.
Fix this recently added section using tabs instead of spaces.
Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
MAINTAINERS | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa67e2624723..c76884e40434 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5296,10 +5296,10 @@ W: http://accessrunner.sourceforge.net/
F: drivers/usb/atm/cxacru.c
CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
-M: Elena Reshetova <elena.reshetova@intel.com>
-M: Carlos Bilbao <carlos.bilbao@amd.com>
-S: Maintained
-F: Documentation/security/snp-tdx-threat-model.rst
+M: Elena Reshetova <elena.reshetova@intel.com>
+M: Carlos Bilbao <carlos.bilbao@amd.com>
+S: Maintained
+F: Documentation/security/snp-tdx-threat-model.rst
CONFIGFS
M: Joel Becker <jlbec@evilplan.org>
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section
2024-01-08 14:08 [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section Lukas Bulwahn
@ 2024-01-08 16:01 ` Carlos Bilbao
0 siblings, 0 replies; 2+ messages in thread
From: Carlos Bilbao @ 2024-01-08 16:01 UTC (permalink / raw)
To: Lukas Bulwahn, Elena Reshetova, Jonathan Corbet, linux-doc
Cc: kernel-janitors, linux-kernel, Jakub Kicinski
Hello,
On 1/8/24 08:08, Lukas Bulwahn wrote:
> Commit 1f597b1a6ec2 ("docs: security: Confidential computing intro and
> threat model for x86 virtualization") adds new documentation and a
> corresponding MAINTAINERS section. It however uses spaces instead of a
> single tab for all the entries in that MAINTAINERS section.
>
> Although, the get_maintainer.pl script handles spaces instead of tabs
> silently, the MAINTAINERS will quickly get into a messy state with
> different indentations throughout the file. So, the checkpatch.pl script
> complains when spaces instead of a single tab are used.
>
> Fix this recently added section using tabs instead of spaces.
>
> Fixes: 1f597b1a6ec2 ("docs: security: Confidential computing intro and threat model for x86 virtualization")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Jakub has already addressed this issue with the patch "[PATCH docs]
MAINTAINERS: use tabs for indent of CONFIDENTIAL COMPUTING THREAT MODEL"
from 1/3/24. Also, I recommend refraining from using the 'Fixes' tag for
things of this nature. NACK.
> ---
> MAINTAINERS | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fa67e2624723..c76884e40434 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5296,10 +5296,10 @@ W: http://accessrunner.sourceforge.net/
> F: drivers/usb/atm/cxacru.c
>
> CONFIDENTIAL COMPUTING THREAT MODEL FOR X86 VIRTUALIZATION (SNP/TDX)
> -M: Elena Reshetova <elena.reshetova@intel.com>
> -M: Carlos Bilbao <carlos.bilbao@amd.com>
> -S: Maintained
> -F: Documentation/security/snp-tdx-threat-model.rst
> +M: Elena Reshetova <elena.reshetova@intel.com>
> +M: Carlos Bilbao <carlos.bilbao@amd.com>
> +S: Maintained
> +F: Documentation/security/snp-tdx-threat-model.rst
>
> CONFIGFS
> M: Joel Becker <jlbec@evilplan.org>
Thanks,
Carlos
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-08 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-08 14:08 [PATCH] MAINTAINERS: use tabs in CONFIDENTIAL COMPUTING THREAT MODEL section Lukas Bulwahn
2024-01-08 16:01 ` Carlos Bilbao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®