From: Viresh Kumar <viresh.kumar@linaro.org>
To: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, vireshk@kernel.org, nm@ti.com,
sboyd@kernel.org, mani@kernel.org, lpieralisi@kernel.org,
kw@linux.com, robh@kernel.org, bhelgaas@google.com,
rafael@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
quic_vbadigan@quicinc.com, quic_nitegupt@quicinc.com,
quic_skananth@quicinc.com, quic_ramkri@quicinc.com,
quic_parass@quicinc.com
Subject: Re: [PATCH v5 5/5] PCI: qcom: Add OPP support to scale performance state of power domain
Date: Wed, 10 Jan 2024 12:27:57 +0530 [thread overview]
Message-ID: <20240110065757.xde2nvpr3z7c4isu@vireshk-i7> (raw)
In-Reply-To: <0ba9f2af-169e-a9a2-9ae4-4c6a70b0a94e@quicinc.com>
On 08-01-24, 18:49, Krishna Chaitanya Chundru wrote:
> We calculate ICC BW voting based up on PCIe speed and PCIe width.
>
> Right now we are adding the opp table based up on PCIe speed.
>
> Each PCIe controller can support multiple lane configurations like x1, x2,
> x4, x8, x16 based up on controller capability.
>
> So for each GEN speed we need up to 5 entries in OPP table. This will make
> OPP table very long.
>
> It is best to calculate the ICC BW voting in the driver itself and apply
> them through ICC driver.
I see. Are the lane configurations fixed for a platform ? I mean, do you change
those configurations at runtime or is that something that never changes, but the
driver can end up getting used on a hardware that supports any one of them ?
If they are fixed (second case), then you can use dev_pm_opp_set_prop_name() to
make that easier for you. With that you will only need 5 OPP entries, but each
of them will have five values of bw:
bw-x1, bw-x2, .... and you can select one of them during initialization.
--
viresh
next prev parent reply other threads:[~2024-01-10 6:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 6:00 [PATCH v5 0/5] PCI: qcom: Add support for OPP Krishna chaitanya chundru
2023-09-07 6:00 ` [PATCH v5 1/5] dt-bindings: pci: qcom: Add opp table Krishna chaitanya chundru
2023-09-07 6:00 ` [PATCH v5 2/5] arm64: dts: qcom: sm8450: Add opp table support to PCIe Krishna chaitanya chundru
2023-09-07 9:04 ` Konrad Dybcio
2023-09-07 9:56 ` Krishna Chaitanya Chundru
2023-09-07 10:28 ` Konrad Dybcio
2023-09-28 18:38 ` Manivannan Sadhasivam
2023-10-05 8:52 ` Krishna Chaitanya Chundru
2023-09-07 6:00 ` [PATCH v5 3/5] opp: Add dev_pm_opp_find_level_floor() Krishna chaitanya chundru
2023-09-27 7:14 ` Viresh Kumar
2023-09-28 3:24 ` Krishna Chaitanya Chundru
2023-09-28 3:35 ` Krishna Chaitanya Chundru
2023-09-07 6:00 ` [PATCH v5 4/5] PCI: qcom: Return error from 'qcom_pcie_icc_update' Krishna chaitanya chundru
2023-11-01 6:30 ` Manivannan Sadhasivam
2023-09-07 6:00 ` [PATCH v5 5/5] PCI: qcom: Add OPP support to scale performance state of power domain Krishna chaitanya chundru
[not found] ` <20230927065324.w73ae326vs5ftlfo@vireshk-i7>
[not found] ` <f7a5ac7f-2857-8d30-e29c-f64c2c5f1330@quicinc.com>
2023-09-28 6:31 ` Viresh Kumar
2023-11-01 6:33 ` Manivannan Sadhasivam
2023-11-01 22:17 ` Bjorn Helgaas
2023-11-02 5:30 ` Viresh Kumar
2023-11-02 12:09 ` Bjorn Helgaas
2023-11-03 5:12 ` Viresh Kumar
2023-11-08 2:32 ` Krishna Chaitanya Chundru
2024-01-08 13:19 ` Krishna Chaitanya Chundru
2024-01-10 6:57 ` Viresh Kumar [this message]
2024-01-10 7:12 ` Krishna Chaitanya Chundru
2024-01-10 7:38 ` Viresh Kumar
2024-01-10 12:58 ` Krishna Chaitanya Chundru
2024-01-11 3:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240110065757.xde2nvpr3z7c4isu@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=nm@ti.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_parass@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®