mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krishna Chaitanya Chundru <quic_krichai@quicinc.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <vireshk@kernel.org>, <nm@ti.com>,
	<sboyd@kernel.org>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<robh@kernel.org>, <bhelgaas@google.com>, <rafael@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <quic_vbadigan@quicinc.com>,
	<quic_nitegupt@quicinc.com>, <quic_skananth@quicinc.com>,
	<quic_ramkri@quicinc.com>, <quic_parass@quicinc.com>
Subject: Re: [PATCH v5 2/5] arm64: dts: qcom: sm8450: Add opp table support to PCIe
Date: Thu, 5 Oct 2023 14:22:49 +0530	[thread overview]
Message-ID: <396a55c1-8ae3-8296-2826-e7ab0f5cb103@quicinc.com> (raw)
In-Reply-To: <20230928183808.GA10963@thinkpad>


On 9/29/2023 12:08 AM, Manivannan Sadhasivam wrote:
> On Thu, Sep 07, 2023 at 11:30:30AM +0530, Krishna chaitanya chundru wrote:
>> PCIe needs to choose the appropriate performance state of RPMH power
>> domain based up on the PCIe gen speed.
>>
>> So let's add the OPP table support to specify RPMH performance states.
>>
>> Use opp-level for the PCIe gen speed for easier use.
>>
> So, you just want to control RPMh performance state using OPP and not clock
> rates? What will happen if you switch to lowest performance state of RPMh but
> still run PCIe clocks at max rate?
>
> - Mani

Based up on the RPMH state the clock rates will be scaled accordingly.

- KC

>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8450.dtsi | 47 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 47 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index 2a60cf8..a6264a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -1820,7 +1820,28 @@
>>   			pinctrl-names = "default";
>>   			pinctrl-0 = <&pcie0_default_state>;
>>   
>> +			operating-points-v2 = <&pcie0_opp_table>;
>> +
>>   			status = "disabled";
>> +
>> +			pcie0_opp_table: opp-table {
>> +				compatible = "operating-points-v2";
>> +
>> +				opp-1 {
>> +					opp-level = <1>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-2 {
>> +					opp-level = <2>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-3 {
>> +					opp-level = <3>;
>> +					required-opps = <&rpmhpd_opp_nom>;
>> +				};
>> +			};
>>   		};
>>   
>>   		pcie0_phy: phy@1c06000 {
>> @@ -1932,7 +1953,33 @@
>>   			pinctrl-names = "default";
>>   			pinctrl-0 = <&pcie1_default_state>;
>>   
>> +			operating-points-v2 = <&pcie1_opp_table>;
>> +
>>   			status = "disabled";
>> +
>> +			pcie1_opp_table: opp-table {
>> +				compatible = "operating-points-v2";
>> +
>> +				opp-1 {
>> +					opp-level = <1>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-2 {
>> +					opp-level = <2>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-3 {
>> +					opp-level = <3>;
>> +					required-opps = <&rpmhpd_opp_low_svs>;
>> +				};
>> +
>> +				opp-4 {
>> +					opp-level = <4>;
>> +					required-opps = <&rpmhpd_opp_nom>;
>> +				};
>> +			};
>>   		};
>>   
>>   		pcie1_phy: phy@1c0f000 {
>> -- 
>> 2.7.4
>>

  reply	other threads:[~2023-10-05 14:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  6:00 [PATCH v5 0/5] PCI: qcom: Add support for OPP Krishna chaitanya chundru
2023-09-07  6:00 ` [PATCH v5 1/5] dt-bindings: pci: qcom: Add opp table Krishna chaitanya chundru
2023-09-07  6:00 ` [PATCH v5 2/5] arm64: dts: qcom: sm8450: Add opp table support to PCIe Krishna chaitanya chundru
2023-09-07  9:04   ` Konrad Dybcio
2023-09-07  9:56     ` Krishna Chaitanya Chundru
2023-09-07 10:28       ` Konrad Dybcio
2023-09-28 18:38   ` Manivannan Sadhasivam
2023-10-05  8:52     ` Krishna Chaitanya Chundru [this message]
2023-09-07  6:00 ` [PATCH v5 3/5] opp: Add dev_pm_opp_find_level_floor() Krishna chaitanya chundru
2023-09-27  7:14   ` Viresh Kumar
2023-09-28  3:24     ` Krishna Chaitanya Chundru
2023-09-28  3:35     ` Krishna Chaitanya Chundru
2023-09-07  6:00 ` [PATCH v5 4/5] PCI: qcom: Return error from 'qcom_pcie_icc_update' Krishna chaitanya chundru
2023-11-01  6:30   ` Manivannan Sadhasivam
2023-09-07  6:00 ` [PATCH v5 5/5] PCI: qcom: Add OPP support to scale performance state of power domain Krishna chaitanya chundru
     [not found]   ` <20230927065324.w73ae326vs5ftlfo@vireshk-i7>
     [not found]     ` <f7a5ac7f-2857-8d30-e29c-f64c2c5f1330@quicinc.com>
2023-09-28  6:31       ` Viresh Kumar
2023-11-01  6:33   ` Manivannan Sadhasivam
2023-11-01 22:17   ` Bjorn Helgaas
2023-11-02  5:30     ` Viresh Kumar
2023-11-02 12:09       ` Bjorn Helgaas
2023-11-03  5:12         ` Viresh Kumar
2023-11-08  2:32           ` Krishna Chaitanya Chundru
2024-01-08 13:19             ` Krishna Chaitanya Chundru
2024-01-10  6:57               ` Viresh Kumar
2024-01-10  7:12                 ` Krishna Chaitanya Chundru
2024-01-10  7:38                   ` Viresh Kumar
2024-01-10 12:58                     ` Krishna Chaitanya Chundru
2024-01-11  3:32                       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=396a55c1-8ae3-8296-2826-e7ab0f5cb103@quicinc.com \
    --to=quic_krichai@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=nm@ti.com \
    --cc=quic_nitegupt@quicinc.com \
    --cc=quic_parass@quicinc.com \
    --cc=quic_ramkri@quicinc.com \
    --cc=quic_skananth@quicinc.com \
    --cc=quic_vbadigan@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®