mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Roderick Colenbrander <roderick.colenbrander@sony.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, max@enpas.org
Subject: [PATCH v1 5/7] HID: playstation: DS4: Parse minimal report 0x01
Date: Mon, 15 Jan 2024 23:45:36 +0900	[thread overview]
Message-ID: <20240115144538.12018-6-max@enpas.org> (raw)
In-Reply-To: <20240115144538.12018-1-max@enpas.org>

Some third-party controllers never switch to the full 0x11 report.

They keep sending the short 0x01 report, so let's parse that instead.

Signed-off-by: Max Staudt <max@enpas.org>
---
 drivers/hid/hid-playstation.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index 2bf44bd3cc8a..086b0768fa51 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -287,6 +287,8 @@ struct dualsense_output_report {
 
 #define DS4_INPUT_REPORT_USB			0x01
 #define DS4_INPUT_REPORT_USB_SIZE		64
+#define DS4_INPUT_REPORT_BT_MINIMAL		0x01
+#define DS4_INPUT_REPORT_BT_MINIMAL_SIZE	10
 #define DS4_INPUT_REPORT_BT			0x11
 #define DS4_INPUT_REPORT_BT_SIZE		78
 #define DS4_OUTPUT_REPORT_USB			0x05
@@ -2198,6 +2200,7 @@ static int dualshock4_parse_report(struct ps_device *ps_dev, struct hid_report *
 	int battery_status, i, j;
 	uint16_t sensor_timestamp;
 	unsigned long flags;
+	bool is_minimal = false;
 
 	/*
 	 * DualShock4 in USB uses the full HID report for reportID 1, but
@@ -2225,6 +2228,18 @@ static int dualshock4_parse_report(struct ps_device *ps_dev, struct hid_report *
 		ds4_report = &bt->common;
 		num_touch_reports = bt->num_touch_reports;
 		touch_reports = bt->touch_reports;
+	} else if (hdev->bus == BUS_BLUETOOTH &&
+		   report->id == DS4_INPUT_REPORT_BT_MINIMAL &&
+			 size == DS4_INPUT_REPORT_BT_MINIMAL_SIZE) {
+		/* Some third-party pads never switch to the full 0x11 report.
+		 * The short 0x01 report is 10 bytes long:
+		 *   u8 report_id == 0x01
+		 *   u8 first_bytes_of_full_report[9]
+		 * So let's reuse the full report parser, and stop it after
+		 * parsing the buttons.
+		 */
+		ds4_report = (struct dualshock4_input_report_common *)&data[1];
+		is_minimal = true;
 	} else {
 		hid_err(hdev, "Unhandled reportID=%d\n", report->id);
 		return -1;
@@ -2258,6 +2273,9 @@ static int dualshock4_parse_report(struct ps_device *ps_dev, struct hid_report *
 	input_report_key(ds4->gamepad, BTN_MODE,   ds4_report->buttons[2] & DS_BUTTONS2_PS_HOME);
 	input_sync(ds4->gamepad);
 
+	if (is_minimal)
+		goto finish_minimal;
+
 	/* Parse and calibrate gyroscope data. */
 	for (i = 0; i < ARRAY_SIZE(ds4_report->gyro); i++) {
 		int raw_data = (short)le16_to_cpu(ds4_report->gyro[i]);
@@ -2365,6 +2383,7 @@ static int dualshock4_parse_report(struct ps_device *ps_dev, struct hid_report *
 	ps_dev->battery_status = battery_status;
 	spin_unlock_irqrestore(&ps_dev->lock, flags);
 
+finish_minimal:
 	return 0;
 }
 
-- 
2.39.2


  parent reply	other threads:[~2024-01-15 14:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 14:45 [PATCH v1 0/7] HID: playstation: DS4: LED bugfix, third-party gamepad support Max Staudt
2024-01-15 14:45 ` [PATCH v1 1/7] HID: playstation: DS4: Fix LED blinking Max Staudt
2024-01-15 14:45 ` [PATCH v1 2/7] HID: playstation: DS4: Don't fail on MAC address request Max Staudt
2024-01-25  0:39   ` Roderick Colenbrander
2024-01-27  8:51     ` Max Staudt
2024-01-30 20:59       ` Roderick Colenbrander
2024-01-31 15:05         ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 3/7] HID: playstation: DS4: Don't fail on FW/HW version request Max Staudt
2024-01-25  0:43   ` Roderick Colenbrander
2024-01-27  8:56     ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 4/7] HID: playstation: DS4: Don't fail on calibration data request Max Staudt
2024-01-15 14:45 ` Max Staudt [this message]
2024-01-25  0:54   ` [PATCH v1 5/7] HID: playstation: DS4: Parse minimal report 0x01 Roderick Colenbrander
2024-01-27  9:00     ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 6/7] HID: playstation: Simplify device type ID Max Staudt
2024-01-25  1:01   ` Roderick Colenbrander
2024-01-15 14:45 ` [PATCH v1 7/7] HID: playstation: DS4: Add VID/PID for SZ-MYPOWER controllers Max Staudt
2024-01-25  1:03   ` Roderick Colenbrander
2024-01-27 11:16     ` Max Staudt
2024-01-30 21:07       ` Roderick Colenbrander
2024-01-31 14:48         ` Max Staudt
2024-01-31 16:34           ` Roderick Colenbrander
2024-02-01 15:56             ` Max Staudt
2024-01-23  9:47 ` [PATCH v1 0/7] HID: playstation: DS4: LED bugfix, third-party gamepad support Jiri Kosina
2024-01-24 22:24   ` Roderick Colenbrander
2024-01-27 11:52     ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240115144538.12018-6-max@enpas.org \
    --to=max@enpas.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roderick.colenbrander@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®