mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Roderick Colenbrander <thunderbird2k@gmail.com>
Cc: Roderick Colenbrander <roderick.colenbrander@sony.com>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/7] HID: playstation: DS4: Don't fail on MAC address request
Date: Sat, 27 Jan 2024 17:51:41 +0900	[thread overview]
Message-ID: <cb8290a0-1937-4937-ace5-e2a22a1f6e41@enpas.org> (raw)
In-Reply-To: <CAEc3jaD9qXp=F6Xfg8bdeC1Hv5pHiKA16SBd=-ac74ibE1ELyw@mail.gmail.com>

On 1/25/24 09:39, Roderick Colenbrander wrote:
> On Mon, Jan 15, 2024 at 6:58 AM Max Staudt <max@enpas.org> wrote:
>>
>> Some third-party controllers can't report their MAC address.
>>
> For what type of devices is this not working? This one example of this
> request which is very foundational for a controller working on even
> the game console. Are this perhaps USB-only devices? If the case maybe
> some kind of error is only needed for USB connections.

IIRC I've only seen this quirk with the oddball VID/PID 7545:0104 that my patch 7/7 adds. It is indeed a USB-only controller. I have not tried this device (or any, really) with an actual console, my focus is just on Linux. Admittedly, I'd also like to know what happens on a real PS4 :)

My intention was to keep the error message and the solution as universal as possible, in case a controller comes along that has both this quirk *and* Bluetooth. It's a bit of an ugly workaround though - if you (or anyone else) have an idea for a nicer solution, I'd be really glad.


Max


  reply	other threads:[~2024-01-27  9:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 14:45 [PATCH v1 0/7] HID: playstation: DS4: LED bugfix, third-party gamepad support Max Staudt
2024-01-15 14:45 ` [PATCH v1 1/7] HID: playstation: DS4: Fix LED blinking Max Staudt
2024-01-15 14:45 ` [PATCH v1 2/7] HID: playstation: DS4: Don't fail on MAC address request Max Staudt
2024-01-25  0:39   ` Roderick Colenbrander
2024-01-27  8:51     ` Max Staudt [this message]
2024-01-30 20:59       ` Roderick Colenbrander
2024-01-31 15:05         ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 3/7] HID: playstation: DS4: Don't fail on FW/HW version request Max Staudt
2024-01-25  0:43   ` Roderick Colenbrander
2024-01-27  8:56     ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 4/7] HID: playstation: DS4: Don't fail on calibration data request Max Staudt
2024-01-15 14:45 ` [PATCH v1 5/7] HID: playstation: DS4: Parse minimal report 0x01 Max Staudt
2024-01-25  0:54   ` Roderick Colenbrander
2024-01-27  9:00     ` Max Staudt
2024-01-15 14:45 ` [PATCH v1 6/7] HID: playstation: Simplify device type ID Max Staudt
2024-01-25  1:01   ` Roderick Colenbrander
2024-01-15 14:45 ` [PATCH v1 7/7] HID: playstation: DS4: Add VID/PID for SZ-MYPOWER controllers Max Staudt
2024-01-25  1:03   ` Roderick Colenbrander
2024-01-27 11:16     ` Max Staudt
2024-01-30 21:07       ` Roderick Colenbrander
2024-01-31 14:48         ` Max Staudt
2024-01-31 16:34           ` Roderick Colenbrander
2024-02-01 15:56             ` Max Staudt
2024-01-23  9:47 ` [PATCH v1 0/7] HID: playstation: DS4: LED bugfix, third-party gamepad support Jiri Kosina
2024-01-24 22:24   ` Roderick Colenbrander
2024-01-27 11:52     ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb8290a0-1937-4937-ace5-e2a22a1f6e41@enpas.org \
    --to=max@enpas.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roderick.colenbrander@sony.com \
    --cc=thunderbird2k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®