From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <richardcochran@gmail.com>,
<Divya.Koppera@microchip.com>, <maxime.chevallier@bootlin.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net v2 2/2] net: micrel: Fix set/get PHC time for lan8814
Date: Fri, 19 Jan 2024 09:21:03 +0100 [thread overview]
Message-ID: <20240119082103.edy647tbf2akokjy@DEN-DL-M31836.microchip.com> (raw)
In-Reply-To: <139fe4c1-6a3e-4ef3-a178-ebbe09652966@lunn.ch>
The 01/18/2024 18:00, Andrew Lunn wrote:
>
> > > Maybe submit this for net-next?
> >
> > Anyway, I don't have strong feelings about this, if it goes to net or
> > net-next, I just want to fix this at some point :)
>
> Please submit to net-next. I think the ML bot which picks out patches
> to backport is likely to see the work Fix in the subject and decided
> to backport it anyway. But its not our problem if the bot breaks the
> stable rules.
Yes, I will do that.
>
> Is there any danger of regressions? Could the higher word actually
> have a value for some reason today, which is being ignored. Would this
> change then jump the time forward?
I am not seeing any danger of regressions.
By default the higher word has a value of 0, and doesn't have any
special functionality to jump forward or backwards. It just contains
upper 16 bits of the second [47:32].
I have seen only on register PTP_LTC_STEP_ADJ_HI that the most significant
bit can signify if to jump forward or backwards.
>
> Andrew
--
/Horatiu
next prev parent reply other threads:[~2024-01-19 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:59 [PATCH net v2 0/2] net: micrel: Fixes for PHC " Horatiu Vultur
2024-01-18 8:59 ` [PATCH net v2 1/2] net: micrel: Fix PTP frame parsing " Horatiu Vultur
2024-01-19 20:01 ` Simon Horman
2024-01-18 8:59 ` [PATCH net v2 2/2] net: micrel: Fix set/get PHC time " Horatiu Vultur
2024-01-18 13:52 ` Andrew Lunn
2024-01-18 15:23 ` Horatiu Vultur
2024-01-18 17:00 ` Andrew Lunn
2024-01-19 8:21 ` Horatiu Vultur [this message]
2024-01-19 13:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240119082103.edy647tbf2akokjy@DEN-DL-M31836.microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®