From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
richardcochran@gmail.com, Divya.Koppera@microchip.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net v2 2/2] net: micrel: Fix set/get PHC time for lan8814
Date: Thu, 18 Jan 2024 14:52:04 +0100 [thread overview]
Message-ID: <6fa37dfd-3c92-4842-9785-1b17bbbedc9d@lunn.ch> (raw)
In-Reply-To: <20240118085916.1204354-3-horatiu.vultur@microchip.com>
On Thu, Jan 18, 2024 at 09:59:16AM +0100, Horatiu Vultur wrote:
> When setting or getting PHC time, the higher bits of the second time (>32
> bits) they were ignored. Meaning that setting some time in the future like
> year 2150, it was failing to set this.
Stable rules say:
It must either fix a real bug that bothers people...
Do we have users of this device in 2150?
Maybe submit this for net-next?
Andrew
next prev parent reply other threads:[~2024-01-18 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 8:59 [PATCH net v2 0/2] net: micrel: Fixes for PHC " Horatiu Vultur
2024-01-18 8:59 ` [PATCH net v2 1/2] net: micrel: Fix PTP frame parsing " Horatiu Vultur
2024-01-19 20:01 ` Simon Horman
2024-01-18 8:59 ` [PATCH net v2 2/2] net: micrel: Fix set/get PHC time " Horatiu Vultur
2024-01-18 13:52 ` Andrew Lunn [this message]
2024-01-18 15:23 ` Horatiu Vultur
2024-01-18 17:00 ` Andrew Lunn
2024-01-19 8:21 ` Horatiu Vultur
2024-01-19 13:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa37dfd-3c92-4842-9785-1b17bbbedc9d@lunn.ch \
--to=andrew@lunn.ch \
--cc=Divya.Koppera@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®