* [PATCH] x86/mm/cpa-test: Correct length selection
@ 2024-01-25 18:24 Jason Andryuk
2024-01-25 18:30 ` Dave Hansen
0 siblings, 1 reply; 3+ messages in thread
From: Jason Andryuk @ 2024-01-25 18:24 UTC (permalink / raw)
To: linux-kernel
Cc: Jason Andryuk, Dave Hansen, Andy Lutomirski, Peter Zijlstra,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin
The length of pages to modify corresponding to addr[i] is given in
len[i]. Remove the hard coded 1.
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
---
This is a typo, right? The other cases use len[i].
arch/x86/mm/pat/cpa-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/mm/pat/cpa-test.c b/arch/x86/mm/pat/cpa-test.c
index 3d2f7f0a6ed1..ad3c1feec990 100644
--- a/arch/x86/mm/pat/cpa-test.c
+++ b/arch/x86/mm/pat/cpa-test.c
@@ -183,7 +183,7 @@ static int pageattr_test(void)
break;
case 1:
- err = change_page_attr_set(addrs, len[1], PAGE_CPA_TEST, 1);
+ err = change_page_attr_set(addrs, len[i], PAGE_CPA_TEST, 1);
break;
case 2:
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/mm/cpa-test: Correct length selection
2024-01-25 18:24 [PATCH] x86/mm/cpa-test: Correct length selection Jason Andryuk
@ 2024-01-25 18:30 ` Dave Hansen
2024-01-25 18:39 ` Jason Andryuk
0 siblings, 1 reply; 3+ messages in thread
From: Dave Hansen @ 2024-01-25 18:30 UTC (permalink / raw)
To: Jason Andryuk, linux-kernel
Cc: Dave Hansen, Andy Lutomirski, Peter Zijlstra, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, x86, H. Peter Anvin
On 1/25/24 10:24, Jason Andryuk wrote:
> The length of pages to modify corresponding to addr[i] is given in
> len[i]. Remove the hard coded 1.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> This is a typo, right? The other cases use len[i].
Sure looks like it to me.
Any idea how this could have gone unnoticed for 5 years?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/mm/cpa-test: Correct length selection
2024-01-25 18:30 ` Dave Hansen
@ 2024-01-25 18:39 ` Jason Andryuk
0 siblings, 0 replies; 3+ messages in thread
From: Jason Andryuk @ 2024-01-25 18:39 UTC (permalink / raw)
To: Dave Hansen
Cc: linux-kernel, Dave Hansen, Andy Lutomirski, Peter Zijlstra,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, x86,
H. Peter Anvin
On Thu, Jan 25, 2024 at 1:30 PM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 1/25/24 10:24, Jason Andryuk wrote:
> > The length of pages to modify corresponding to addr[i] is given in
> > len[i]. Remove the hard coded 1.
> >
> > Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> > ---
> > This is a typo, right? The other cases use len[i].
>
> Sure looks like it to me.
>
> Any idea how this could have gone unnoticed for 5 years?
Not really, which is why I wondered if I was missing something.
Regards,
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-25 18:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 18:24 [PATCH] x86/mm/cpa-test: Correct length selection Jason Andryuk
2024-01-25 18:30 ` Dave Hansen
2024-01-25 18:39 ` Jason Andryuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®