From: Qais Yousef <qyousef@layalina.io>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [PATCH v4 1/2] sched/fair: Check a task has a fitting cpu when updating misfit
Date: Fri, 26 Jan 2024 00:37:14 +0000 [thread overview]
Message-ID: <20240126003714.tru4tz2pzjg5jnvf@airbuntu> (raw)
In-Reply-To: <CAKfTPtDnxsOS0je9DgMc5ZCLPXA6QRLz14t6o_ht7rvxbAbc9A@mail.gmail.com>
On 01/25/24 18:44, Vincent Guittot wrote:
> On Wed, 24 Jan 2024 at 23:46, Qais Yousef <qyousef@layalina.io> wrote:
> >
> > On 01/23/24 09:32, Vincent Guittot wrote:
> >
> > > > > @@ -9583,9 +9630,7 @@ check_cpu_capacity(struct rq *rq, struct sched_domain *sd)
> > > > > */
> > > > > static inline int check_misfit_status(struct rq *rq, struct sched_domain *sd)
> > > > > {
> > > > > - return rq->misfit_task_load &&
> > > > > - (arch_scale_cpu_capacity(rq->cpu) < rq->rd->max_cpu_capacity ||
> > > > > - check_cpu_capacity(rq, sd));
> > > > > + return rq->misfit_task_load && check_cpu_capacity(rq, sd);
>
> Coming back to this:
> With your change above, misfit can't kick an idle load balance and
> must wait for the cpu capacity being noticeably reduced by something
> else
Good catch, yes. It's a subtle change. We need to keep this and better add
a comment that we move immediately for all CPUs except the biggest one where we
need to check_cpu_capacity().
next prev parent reply other threads:[~2024-01-26 0:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 22:20 [PATCH v4 0/2] sched: Don't trigger misfit if affinity is restricted Qais Yousef
2024-01-05 22:20 ` [PATCH v4 1/2] sched/fair: Check a task has a fitting cpu when updating misfit Qais Yousef
2024-01-22 9:59 ` Dietmar Eggemann
2024-01-22 18:02 ` Qais Yousef
2024-01-23 18:07 ` Dietmar Eggemann
2024-01-24 22:43 ` Qais Yousef
2024-01-25 10:35 ` Dietmar Eggemann
2024-01-26 0:47 ` Qais Yousef
2024-01-23 8:32 ` Vincent Guittot
2024-01-24 22:46 ` Qais Yousef
2024-01-25 17:44 ` Vincent Guittot
2024-01-26 0:37 ` Qais Yousef [this message]
2024-01-23 8:26 ` Vincent Guittot
2024-01-24 22:29 ` Qais Yousef
2024-01-25 17:40 ` Vincent Guittot
2024-01-26 1:46 ` Qais Yousef
2024-01-26 14:08 ` Vincent Guittot
2024-01-28 23:50 ` Qais Yousef
2024-01-29 22:53 ` Qais Yousef
2024-01-30 9:41 ` Vincent Guittot
2024-01-30 23:57 ` Qais Yousef
2024-01-31 13:55 ` Vincent Guittot
2024-02-01 22:21 ` Qais Yousef
2024-02-05 19:49 ` Dietmar Eggemann
2024-02-06 15:06 ` Qais Yousef
2024-02-06 17:17 ` Dietmar Eggemann
2024-02-20 16:07 ` Qais Yousef
2024-01-23 17:22 ` Vincent Guittot
2024-01-24 22:38 ` Qais Yousef
2024-01-25 17:50 ` Vincent Guittot
2024-01-26 2:07 ` Qais Yousef
2024-01-26 14:15 ` Vincent Guittot
2024-01-28 23:32 ` Qais Yousef
2024-01-05 22:20 ` [PATCH v4 2/2] sched/topology: Sort asym_cap_list in descending order Qais Yousef
2024-01-21 0:10 ` [PATCH v4 0/2] sched: Don't trigger misfit if affinity is restricted Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126003714.tru4tz2pzjg5jnvf@airbuntu \
--to=qyousef@layalina.io \
--cc=Pierre.Gondois@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®