From: Qais Yousef <qyousef@layalina.io>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org,
Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [PATCH v4 1/2] sched/fair: Check a task has a fitting cpu when updating misfit
Date: Tue, 20 Feb 2024 16:07:37 +0000 [thread overview]
Message-ID: <20240220160737.jlpewyyq3hp5nwgs@airbuntu> (raw)
In-Reply-To: <f58fb725-39b6-4b76-bc23-bc0526bddccb@arm.com>
On 02/06/24 18:17, Dietmar Eggemann wrote:
> On 06/02/2024 16:06, Qais Yousef wrote:
> > On 02/05/24 20:49, Dietmar Eggemann wrote:
> >> On 26/01/2024 02:46, Qais Yousef wrote:
> >>> On 01/25/24 18:40, Vincent Guittot wrote:
> >>>> On Wed, 24 Jan 2024 at 23:30, Qais Yousef <qyousef@layalina.io> wrote:
> >>>>>
> >>>>> On 01/23/24 09:26, Vincent Guittot wrote:
> >>>>>> On Fri, 5 Jan 2024 at 23:20, Qais Yousef <qyousef@layalina.io> wrote:
> >>>>>>>
> >>>>>>> From: Qais Yousef <qais.yousef@arm.com>
>
> [...]
>
> >>> It seems we flatten topologies but not sched domains. I see all cpus shown as
> >>> core_siblings. The DT for apple silicon sets clusters in the cpu-map - which
> >>> seems the flatten topology stuff detect LLC correctly but still keeps the
> >>> sched-domains not flattened. Is this a bug? I thought we will end up with one
> >>> sched domain still.
> >>
> >> IMHO, if you have a cpu_map entry with > 1 cluster in your dtb, you end
> >> up with MC and PKG (former DIE) Sched Domain (SD) level. And misfit load
> >
> > Hmm, okay. I thought the detection of topology where we know the LLC is shared
> > will cause the sched domains to collapse too.
> >
> >> balance takes potentially longer on PKG than to MC.
> >
> > Why potentially longer? We iterate through the domains the CPU belong to. If
> > the first iteration (at MC) pulled something, then once we go to PKG then we're
> > less likely to pull again?
>
> There are a couple of mechanisms in place to let load-balance on higher
> sd levels happen less frequently, eg:
>
> load_balance() -> should_we_balance() + continue_balancing
>
> interval = get_sd_balance_interval(sd, busy) in rebalance_domains()
>
> rq->avg_idle versus sd->max_newidle_lb_cost
Okay thanks. That last one I missed.
>
> > Anyway. I think I am hitting a bug here. The behavior doesn't look right to me
> > given the delays I'm seeing and the fact we do the ilb but for some reason fail
> > to pull
>
> [...]
>
next prev parent reply other threads:[~2024-02-20 16:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 22:20 [PATCH v4 0/2] sched: Don't trigger misfit if affinity is restricted Qais Yousef
2024-01-05 22:20 ` [PATCH v4 1/2] sched/fair: Check a task has a fitting cpu when updating misfit Qais Yousef
2024-01-22 9:59 ` Dietmar Eggemann
2024-01-22 18:02 ` Qais Yousef
2024-01-23 18:07 ` Dietmar Eggemann
2024-01-24 22:43 ` Qais Yousef
2024-01-25 10:35 ` Dietmar Eggemann
2024-01-26 0:47 ` Qais Yousef
2024-01-23 8:32 ` Vincent Guittot
2024-01-24 22:46 ` Qais Yousef
2024-01-25 17:44 ` Vincent Guittot
2024-01-26 0:37 ` Qais Yousef
2024-01-23 8:26 ` Vincent Guittot
2024-01-24 22:29 ` Qais Yousef
2024-01-25 17:40 ` Vincent Guittot
2024-01-26 1:46 ` Qais Yousef
2024-01-26 14:08 ` Vincent Guittot
2024-01-28 23:50 ` Qais Yousef
2024-01-29 22:53 ` Qais Yousef
2024-01-30 9:41 ` Vincent Guittot
2024-01-30 23:57 ` Qais Yousef
2024-01-31 13:55 ` Vincent Guittot
2024-02-01 22:21 ` Qais Yousef
2024-02-05 19:49 ` Dietmar Eggemann
2024-02-06 15:06 ` Qais Yousef
2024-02-06 17:17 ` Dietmar Eggemann
2024-02-20 16:07 ` Qais Yousef [this message]
2024-01-23 17:22 ` Vincent Guittot
2024-01-24 22:38 ` Qais Yousef
2024-01-25 17:50 ` Vincent Guittot
2024-01-26 2:07 ` Qais Yousef
2024-01-26 14:15 ` Vincent Guittot
2024-01-28 23:32 ` Qais Yousef
2024-01-05 22:20 ` [PATCH v4 2/2] sched/topology: Sort asym_cap_list in descending order Qais Yousef
2024-01-21 0:10 ` [PATCH v4 0/2] sched: Don't trigger misfit if affinity is restricted Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220160737.jlpewyyq3hp5nwgs@airbuntu \
--to=qyousef@layalina.io \
--cc=Pierre.Gondois@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®