* [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK
@ 2024-01-30 15:29 Naresh Solanki
2024-01-30 16:31 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Naresh Solanki @ 2024-01-30 15:29 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare
Cc: mazziesaccount, Patrick Rudolph, Naresh Solanki, linux-hwmon,
linux-kernel
From: Patrick Rudolph <patrick.rudolph@9elements.com>
Use _pmbus_write_word_data to allow intercepting writes to
PMBUS_SMBALERT_MASK in the custom chip specific code.
This is required for MP2971/MP2973 which doesn't follow the
PMBUS specification for PMBUS_SMBALERT_MASK.
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
drivers/hwmon/pmbus/pmbus_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 1363d9f89181..cb4c65a7f288 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -3188,7 +3188,7 @@ static int pmbus_regulator_notify(struct pmbus_data *data, int page, int event)
static int pmbus_write_smbalert_mask(struct i2c_client *client, u8 page, u8 reg, u8 val)
{
- return pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
+ return _pmbus_write_word_data(client, page, PMBUS_SMBALERT_MASK, reg | (val << 8));
}
static irqreturn_t pmbus_fault_handler(int irq, void *pdata)
base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a
--
2.42.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK
2024-01-30 15:29 [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK Naresh Solanki
@ 2024-01-30 16:31 ` Guenter Roeck
2024-01-30 17:01 ` Naresh Solanki
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2024-01-30 16:31 UTC (permalink / raw)
To: Naresh Solanki
Cc: Jean Delvare, mazziesaccount, Patrick Rudolph, linux-hwmon, linux-kernel
On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> Use _pmbus_write_word_data to allow intercepting writes to
> PMBUS_SMBALERT_MASK in the custom chip specific code.
>
> This is required for MP2971/MP2973 which doesn't follow the
> PMBUS specification for PMBUS_SMBALERT_MASK.
Applied, but is there going to be a follow-up patch for those chips ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK
2024-01-30 16:31 ` Guenter Roeck
@ 2024-01-30 17:01 ` Naresh Solanki
0 siblings, 0 replies; 3+ messages in thread
From: Naresh Solanki @ 2024-01-30 17:01 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jean Delvare, mazziesaccount, Patrick Rudolph, linux-hwmon, linux-kernel
Hi Guenter,
On Tue, 30 Jan 2024 at 22:01, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Tue, Jan 30, 2024 at 08:59:03PM +0530, Naresh Solanki wrote:
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Use _pmbus_write_word_data to allow intercepting writes to
> > PMBUS_SMBALERT_MASK in the custom chip specific code.
> >
> > This is required for MP2971/MP2973 which doesn't follow the
> > PMBUS specification for PMBUS_SMBALERT_MASK.
>
> Applied, but is there going to be a follow-up patch for those chips ?
Yes.
Regards,
Naresh
>
> Thanks,
> Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-30 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30 15:29 [PATCH] hwmon: (pmbus_core) Allow to hook PMBUS_SMBALERT_MASK Naresh Solanki
2024-01-30 16:31 ` Guenter Roeck
2024-01-30 17:01 ` Naresh Solanki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®