mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
@ 2024-01-23  8:33 Krzysztof Kozlowski
  2024-01-30 20:39 ` Rob Herring
  2024-01-30 20:39 ` Rob Herring
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-23  8:33 UTC (permalink / raw)
  To: Daniel Lezcano, Thomas Gleixner, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Marc Zyngier, Mark Rutland,
	linux-kernel, devicetree
  Cc: Krzysztof Kozlowski

Regular expression used to match the unit address part should not allow
non-hex numbers.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
index 7a4a6ab85970..5b9fda2a81e0 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
@@ -60,7 +60,7 @@ properties:
       be implemented in an always-on power domain."
 
 patternProperties:
-  '^frame@[0-9a-z]*$':
+  '^frame@[0-9a-f]*$':
     type: object
     additionalProperties: false
     description: A timer node has up to 8 frame sub-nodes, each with the following properties.
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
  2024-01-23  8:33 [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers Krzysztof Kozlowski
@ 2024-01-30 20:39 ` Rob Herring
  2024-01-30 20:39 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-01-30 20:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Daniel Lezcano, Thomas Gleixner, Krzysztof Kozlowski,
	Conor Dooley, Marc Zyngier, Mark Rutland, linux-kernel,
	devicetree

On Tue, Jan 23, 2024 at 09:33:12AM +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> index 7a4a6ab85970..5b9fda2a81e0 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> @@ -60,7 +60,7 @@ properties:
>        be implemented in an always-on power domain."
>  
>  patternProperties:
> -  '^frame@[0-9a-z]*$':
> +  '^frame@[0-9a-f]*$':

Technically, it should be '+' rather than '*'. But I'm pretty sure 
generically we check that node name can't end with '@'.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
  2024-01-23  8:33 [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers Krzysztof Kozlowski
  2024-01-30 20:39 ` Rob Herring
@ 2024-01-30 20:39 ` Rob Herring
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2024-01-30 20:39 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Marc Zyngier, Thomas Gleixner, Rob Herring, Conor Dooley,
	Mark Rutland, devicetree, Krzysztof Kozlowski, Daniel Lezcano,
	linux-kernel


On Tue, 23 Jan 2024 09:33:12 +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-30 20:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-23  8:33 [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers Krzysztof Kozlowski
2024-01-30 20:39 ` Rob Herring
2024-01-30 20:39 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®