From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Zhao Liu <zhao1.liu@intel.com>,
Zhuocheng Ding <zhuocheng.ding@intel.com>,
x86@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Zhao Liu <zhao1.liu@linux.intel.com>
Subject: Re: [PATCH 8/9] x86/hreset: Configure history reset
Date: Sat, 3 Feb 2024 19:55:52 -0800 [thread overview]
Message-ID: <20240204035552.GC26316@ranerica-svr.sc.intel.com> (raw)
In-Reply-To: <20240203093857.GBZb4JsahiDx2Ouegj@fat_crate.local>
On Sat, Feb 03, 2024 at 10:38:57AM +0100, Borislav Petkov wrote:
> On Fri, Feb 02, 2024 at 08:05:14PM -0800, Ricardo Neri wrote:
> > +static __always_inline void setup_hreset(struct cpuinfo_x86 *c)
> > +{
> > + if (!cpu_feature_enabled(X86_FEATURE_HRESET))
> > + return;
> > +
> > + /*
> > + * Use on all CPUs the hardware history features that the boot
> > + * CPU supports.
> > + */
> > + if (c == &boot_cpu_data)
> > + hardware_history_features = cpuid_ebx(0x20);
>
> That's not what this does - that sets hardware_history_features on the
> BSP.
I meant to say that we will use the features that the BSP supports and
use them to configure all other CPUs. I will reword the comment to make
this clear.
>
> Why isn't this whole thing called in bsp_init_intel()?
The register MSR_IA32_HW_HRESET_ENABLE needs to be configured on each CPU.
I can set hardware_history_features from bsp_init_intel() but I still
need to call setup_hreset() on every CPU.
next prev parent reply other threads:[~2024-02-04 3:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 4:05 [PATCH 0/9] thermal: intel: hfi: Prework for the virtualization of HFI Ricardo Neri
2024-02-03 4:05 ` [PATCH 1/9] thermal: intel: hfi: Relocate bit definitions of HFI registers Ricardo Neri
2024-02-03 4:05 ` [PATCH 2/9] thermal: intel: hfi: Introduce the hfi_table structure Ricardo Neri
2024-02-03 4:05 ` [PATCH 3/9] thermal: intel: hfi: Move selected data structures to a header file Ricardo Neri
2024-02-03 4:05 ` [PATCH 4/9] thermal: intel: hfi: Introduce Intel Thread Director classes Ricardo Neri
2024-02-03 4:05 ` [PATCH 5/9] x86/cpufeatures: Add the Intel Thread Director feature definitions Ricardo Neri
2024-02-03 4:05 ` [PATCH 6/9] thermal: intel: hfi: Enable Intel Thread Director Ricardo Neri
2024-02-05 10:28 ` Stanislaw Gruszka
2024-02-06 2:57 ` Ricardo Neri
2024-02-03 4:05 ` [PATCH 7/9] x86/cpufeatures: Add feature bit for HRESET Ricardo Neri
2024-02-03 9:36 ` Borislav Petkov
2024-02-04 3:49 ` Ricardo Neri
2024-02-03 4:05 ` [PATCH 8/9] x86/hreset: Configure history reset Ricardo Neri
2024-02-03 9:38 ` Borislav Petkov
2024-02-04 3:55 ` Ricardo Neri [this message]
2024-02-04 10:49 ` Borislav Petkov
2024-02-06 2:37 ` Ricardo Neri
2024-02-03 4:05 ` [PATCH 9/9] x86/cpu: Introduce interface to reset hardware history Ricardo Neri
2024-02-03 9:40 ` Borislav Petkov
2024-02-04 3:48 ` Ricardo Neri
2024-02-06 2:59 ` [PATCH 0/9] thermal: intel: hfi: Prework for the virtualization of HFI Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204035552.GC26316@ranerica-svr.sc.intel.com \
--to=ricardo.neri-calderon@linux.intel.com \
--cc=bp@alien8.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®