* [PATCH] mmc: wbsd: remove redundant assignment to variable id
@ 2024-02-05 19:13 Colin Ian King
2024-02-06 11:18 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-05 19:13 UTC (permalink / raw)
To: Pierre Ossman, Ulf Hansson, linux-mmc; +Cc: kernel-janitors, linux-kernel
The variable id is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.
Cleans up clang scan build warning:
drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/mmc/host/wbsd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 001a468bc149..f0562f712d98 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host)
continue;
for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) {
- id = 0xFFFF;
-
host->config = config_ports[i];
host->unlock_code = unlock_codes[j];
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: wbsd: remove redundant assignment to variable id
2024-02-05 19:13 [PATCH] mmc: wbsd: remove redundant assignment to variable id Colin Ian King
@ 2024-02-06 11:18 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2024-02-06 11:18 UTC (permalink / raw)
To: Colin Ian King; +Cc: Pierre Ossman, linux-mmc, kernel-janitors, linux-kernel
On Mon, 5 Feb 2024 at 20:13, Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The variable id is being initialized with a value that is never
> read, it is being re-assigned later on. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/mmc/host/wbsd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
> index 001a468bc149..f0562f712d98 100644
> --- a/drivers/mmc/host/wbsd.c
> +++ b/drivers/mmc/host/wbsd.c
> @@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host)
> continue;
>
> for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) {
> - id = 0xFFFF;
> -
> host->config = config_ports[i];
> host->unlock_code = unlock_codes[j];
A few lines down there is check "if (id != 0xFFFF)". Looks like that
is a redundant check. Would you mind cleaning up that part too, as a
part of the $subject patch?
Kind regards
Uffe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-06 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-05 19:13 [PATCH] mmc: wbsd: remove redundant assignment to variable id Colin Ian King
2024-02-06 11:18 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®