mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: William Zhang <william.zhang@broadcom.com>
To: Linux MTD List <linux-mtd@lists.infradead.org>,
	Linux ARM List <linux-arm-kernel@lists.infradead.org>,
	Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>
Cc: f.fainelli@gmail.com, kursad.oney@broadcom.com,
	joel.peshkin@broadcom.com, anand.gore@broadcom.com,
	dregan@mail.com, kamal.dasu@broadcom.com,
	tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com,
	David Regan <dregan@broadcom.com>,
	William Zhang <william.zhang@broadcom.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Richard Weinberger <richard@nod.at>
Subject: [PATCH v5 12/12] mtd: rawnand: brcmnand: update log level messages
Date: Wed,  7 Feb 2024 12:22:57 -0800	[thread overview]
Message-ID: <20240207202257.271784-13-william.zhang@broadcom.com> (raw)
In-Reply-To: <20240207202257.271784-1-william.zhang@broadcom.com>

From: David Regan <dregan@broadcom.com>

Update log level messages so that more critical messages can be logged
to console and help the troubleshooting with field devices.

Signed-off-by: David Regan <dregan@broadcom.com>
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: William Zhang <william.zhang@broadcom.com>

---

Changes in v5:
- Update the commit message

Changes in v4:
- Revert the log level change for correctable ecc error

Changes in v3: None
Changes in v2:
- Added to patch series

 drivers/mtd/nand/raw/brcmnand/brcmnand.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
index 7ce2b267676f..e50582b45182 100644
--- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c
+++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c
@@ -1143,7 +1143,7 @@ static int bcmnand_ctrl_poll_status(struct brcmnand_host *host,
 	if ((val & mask) == expected_val)
 		return 0;
 
-	dev_warn(ctrl->dev, "timeout on status poll (expected %x got %x)\n",
+	dev_err(ctrl->dev, "timeout on status poll (expected %x got %x)\n",
 		 expected_val, val & mask);
 
 	return -ETIMEDOUT;
@@ -2196,7 +2196,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
 				return err;
 		}
 
-		dev_dbg(ctrl->dev, "uncorrectable error at 0x%llx\n",
+		dev_err(ctrl->dev, "uncorrectable error at 0x%llx\n",
 			(unsigned long long)err_addr);
 		mtd->ecc_stats.failed++;
 		/* NAND layer expects zero on ECC errors */
-- 
2.37.3


      parent reply	other threads:[~2024-02-07 20:24 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 20:22 [PATCH v5 00/12] mtd: rawnand: brcmnand: driver and doc updates William Zhang
2024-02-07 20:22 ` [PATCH v5 01/12] dt-bindings: mtd: brcmnand: Updates for bcmbca SoCs William Zhang
2024-02-22  0:34   ` Florian Fainelli
2024-02-07 20:22 ` [PATCH v5 02/12] dt-bindings: mtd: brcmnand: Add WP pin connection property William Zhang
2024-02-09 17:34   ` Conor Dooley
2024-02-22  0:35   ` Florian Fainelli
2024-02-07 20:22 ` [PATCH v5 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property William Zhang
2024-02-09 17:42   ` Conor Dooley
2024-02-20  9:56   ` Miquel Raynal
2024-02-07 20:22 ` [PATCH v5 04/12] ARM: dts: broadcom: bcmbca: Add NAND controller node William Zhang
2024-02-22  0:39   ` Florian Fainelli
2024-02-22  7:01     ` William Zhang
2024-02-07 20:22 ` [PATCH v5 05/12] arm64: " William Zhang
2024-02-22  8:27   ` Rafał Miłecki
2024-02-22 16:21     ` William Zhang
2024-02-07 20:22 ` [PATCH v5 06/12] arm64: dts: broadcom: bcmbca: Update router boards William Zhang
2024-02-22  0:37   ` Florian Fainelli
2024-02-22  0:40     ` Florian Fainelli
2024-02-22  7:02       ` William Zhang
2024-02-07 20:22 ` [PATCH v5 07/12] mtd: rawnand: brcmnand: Rename bcm63138 nand driver William Zhang
2024-02-07 20:22 ` [PATCH v5 08/12] mtd: rawnand: brcmnand: Add BCMBCA read data bus interface William Zhang
2024-02-07 20:22 ` [PATCH v5 09/12] mtd: rawnand: brcmnand: Add support for getting ecc setting from strap William Zhang
2024-02-20  9:53   ` Miquel Raynal
2024-02-23  3:35     ` William Zhang
2024-02-20  9:58   ` Miquel Raynal
2024-02-07 20:22 ` [PATCH v5 10/12] mtd: rawnand: brcmnand: Support write protection setting from dts William Zhang
2024-02-07 20:22 ` [PATCH v5 11/12] mtd: rawnand: brcmnand: exec_op helper functions return type fixes William Zhang
2024-02-20 10:01   ` Miquel Raynal
2024-02-20 10:02   ` Miquel Raynal
2024-02-21  1:11     ` William Zhang
2024-02-21  6:16     ` Dan Carpenter
2024-02-21  8:32       ` Miquel Raynal
2024-02-21 16:01         ` Florian Fainelli
2024-02-07 20:22 ` William Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207202257.271784-13-william.zhang@broadcom.com \
    --to=william.zhang@broadcom.com \
    --cc=anand.gore@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=dan.beygelman@broadcom.com \
    --cc=dregan@broadcom.com \
    --cc=dregan@mail.com \
    --cc=f.fainelli@gmail.com \
    --cc=joel.peshkin@broadcom.com \
    --cc=kamal.dasu@broadcom.com \
    --cc=kursad.oney@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=tomer.yacoby@broadcom.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®