From: Christian Brauner <brauner@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: NeilBrown <neilb@suse.de>, Jeff Layton <jlayton@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Luca Vizzarro <Luca.Vizzarro@arm.com>,
Tom Talpey <tom@talpey.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] filelock: ignore 'lock' argument to for_each_file_lock()
Date: Mon, 12 Feb 2024 13:07:02 +0100 [thread overview]
Message-ID: <20240212-packpapier-messstation-c5a0c081a0c7@brauner> (raw)
In-Reply-To: <20240212112620.1272058-1-arnd@kernel.org>
On Mon, Feb 12, 2024 at 12:26:11PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When CONFIG_FILE_LOCKING is disabled, ceph causes a warning about
> a variable that is only used insode of the for_each_file_lock()
> loop:
>
> fs/ceph/locks.c: In function 'ceph_count_locks':
> fs/ceph/locks.c:380:27: error: unused variable 'lock' [-Werror=unused-variable]
> 380 | struct file_lock *lock;
>
> Rather than working around this in ceph, change the macro definition
> to still contain a reference to the variable in order to shut up the
> warning.
>
> Fixes: 75cabec0111b ("filelock: add some new helper functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Yup, seems good to me.
next prev parent reply other threads:[~2024-02-12 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:26 Arnd Bergmann
2024-02-12 12:07 ` Christian Brauner [this message]
2024-02-12 12:08 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212-packpapier-messstation-c5a0c081a0c7@brauner \
--to=brauner@kernel.org \
--cc=Luca.Vizzarro@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®