* [PATCH] Documentation: gpio: clarify sysfs line values are logical
@ 2024-02-12 9:34 Kent Gibson
2024-02-12 9:54 ` Andy Shevchenko
2024-02-14 9:29 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Kent Gibson @ 2024-02-12 9:34 UTC (permalink / raw)
To: linux-kernel, linux-gpio, linux-doc, brgl, linus.walleij, andy, corbet
Cc: Kent Gibson
Clarify that line values are logical, not physical, by replacing high/low
terminology with active/inactive.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
Documentation/userspace-api/gpio/sysfs.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/userspace-api/gpio/sysfs.rst b/Documentation/userspace-api/gpio/sysfs.rst
index e12037a0f2b4..116921048b18 100644
--- a/Documentation/userspace-api/gpio/sysfs.rst
+++ b/Documentation/userspace-api/gpio/sysfs.rst
@@ -87,9 +87,9 @@ and have the following read/write attributes:
allow userspace to reconfigure this GPIO's direction.
"value" ...
- reads as either 0 (low) or 1 (high). If the GPIO
+ reads as either 0 (inactive) or 1 (active). If the GPIO
is configured as an output, this value may be written;
- any nonzero value is treated as high.
+ any nonzero value is treated as active.
If the pin can be configured as interrupt-generating interrupt
and if it has been configured to generate interrupts (see the
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: gpio: clarify sysfs line values are logical
2024-02-12 9:34 [PATCH] Documentation: gpio: clarify sysfs line values are logical Kent Gibson
@ 2024-02-12 9:54 ` Andy Shevchenko
2024-02-14 9:29 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-02-12 9:54 UTC (permalink / raw)
To: Kent Gibson
Cc: linux-kernel, linux-gpio, linux-doc, brgl, linus.walleij, andy, corbet
On Mon, Feb 12, 2024 at 11:34 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> Clarify that line values are logical, not physical, by replacing high/low
> terminology with active/inactive.
For this
Reviewed-by: Andy Shevchenko <amdy.shevchenko@gmail.com>
But as I said there are much more...
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: gpio: clarify sysfs line values are logical
2024-02-12 9:34 [PATCH] Documentation: gpio: clarify sysfs line values are logical Kent Gibson
2024-02-12 9:54 ` Andy Shevchenko
@ 2024-02-14 9:29 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2024-02-14 9:29 UTC (permalink / raw)
To: Kent Gibson
Cc: linux-kernel, linux-gpio, linux-doc, linus.walleij, andy, corbet
On Mon, Feb 12, 2024 at 10:34 AM Kent Gibson <warthog618@gmail.com> wrote:
>
> Clarify that line values are logical, not physical, by replacing high/low
> terminology with active/inactive.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
> Documentation/userspace-api/gpio/sysfs.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/userspace-api/gpio/sysfs.rst b/Documentation/userspace-api/gpio/sysfs.rst
> index e12037a0f2b4..116921048b18 100644
> --- a/Documentation/userspace-api/gpio/sysfs.rst
> +++ b/Documentation/userspace-api/gpio/sysfs.rst
> @@ -87,9 +87,9 @@ and have the following read/write attributes:
> allow userspace to reconfigure this GPIO's direction.
>
> "value" ...
> - reads as either 0 (low) or 1 (high). If the GPIO
> + reads as either 0 (inactive) or 1 (active). If the GPIO
> is configured as an output, this value may be written;
> - any nonzero value is treated as high.
> + any nonzero value is treated as active.
>
> If the pin can be configured as interrupt-generating interrupt
> and if it has been configured to generate interrupts (see the
> --
> 2.39.2
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-14 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 9:34 [PATCH] Documentation: gpio: clarify sysfs line values are logical Kent Gibson
2024-02-12 9:54 ` Andy Shevchenko
2024-02-14 9:29 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®