mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] regulator (max5970): Fix regulator child node name
@ 2024-02-13 14:58 Naresh Solanki
  2024-02-13 15:37 ` Mark Brown
  2024-02-13 21:58 ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Naresh Solanki @ 2024-02-13 14:58 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown; +Cc: mazziesaccount, Naresh Solanki, linux-kernel

Update regulator child node name to lower case i.e., sw0 & sw1 as
descibed in max5970 dt binding.

Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
 drivers/regulator/max5970-regulator.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/max5970-regulator.c b/drivers/regulator/max5970-regulator.c
index 830a1c4cd705..8bbcd983a74a 100644
--- a/drivers/regulator/max5970-regulator.c
+++ b/drivers/regulator/max5970-regulator.c
@@ -29,8 +29,8 @@ struct max5970_regulator {
 };
 
 enum max597x_regulator_id {
-	MAX597X_SW0,
-	MAX597X_SW1,
+	MAX597X_sw0,
+	MAX597X_sw1,
 };
 
 static int max5970_read_adc(struct regmap *regmap, int reg, long *val)
@@ -378,8 +378,8 @@ static int max597x_dt_parse(struct device_node *np,
 }
 
 static const struct regulator_desc regulators[] = {
-	MAX597X_SWITCH(SW0, MAX5970_REG_CHXEN, 0, "vss1"),
-	MAX597X_SWITCH(SW1, MAX5970_REG_CHXEN, 1, "vss2"),
+	MAX597X_SWITCH(sw0, MAX5970_REG_CHXEN, 0, "vss1"),
+	MAX597X_SWITCH(sw1, MAX5970_REG_CHXEN, 1, "vss2"),
 };
 
 static int max597x_regmap_read_clear(struct regmap *map, unsigned int reg,

base-commit: 3240695334aa17325671e9ef37bba43038fc4181
-- 
2.42.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator (max5970): Fix regulator child node name
  2024-02-13 14:58 [PATCH] regulator (max5970): Fix regulator child node name Naresh Solanki
@ 2024-02-13 15:37 ` Mark Brown
  2024-02-13 17:37   ` Naresh Solanki
  2024-02-13 21:58 ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2024-02-13 15:37 UTC (permalink / raw)
  To: Naresh Solanki; +Cc: Liam Girdwood, mazziesaccount, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Tue, Feb 13, 2024 at 08:28:00PM +0530, Naresh Solanki wrote:
> Update regulator child node name to lower case i.e., sw0 & sw1 as
> descibed in max5970 dt binding.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator (max5970): Fix regulator child node name
  2024-02-13 15:37 ` Mark Brown
@ 2024-02-13 17:37   ` Naresh Solanki
  0 siblings, 0 replies; 4+ messages in thread
From: Naresh Solanki @ 2024-02-13 17:37 UTC (permalink / raw)
  To: Mark Brown; +Cc: Liam Girdwood, mazziesaccount, linux-kernel

Hi,


On Tue, 13 Feb 2024 at 21:07, Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Feb 13, 2024 at 08:28:00PM +0530, Naresh Solanki wrote:
> > Update regulator child node name to lower case i.e., sw0 & sw1 as
> > descibed in max5970 dt binding.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Ack.

Regards,
Naresh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] regulator (max5970): Fix regulator child node name
  2024-02-13 14:58 [PATCH] regulator (max5970): Fix regulator child node name Naresh Solanki
  2024-02-13 15:37 ` Mark Brown
@ 2024-02-13 21:58 ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-02-13 21:58 UTC (permalink / raw)
  To: Liam Girdwood, Naresh Solanki; +Cc: mazziesaccount, linux-kernel

On Tue, 13 Feb 2024 20:28:00 +0530, Naresh Solanki wrote:
> Update regulator child node name to lower case i.e., sw0 & sw1 as
> descibed in max5970 dt binding.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator (max5970): Fix regulator child node name
      commit: e5d40e9afd84cec01cdbbbfe62d52f89959ab3ee

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-13 21:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-13 14:58 [PATCH] regulator (max5970): Fix regulator child node name Naresh Solanki
2024-02-13 15:37 ` Mark Brown
2024-02-13 17:37   ` Naresh Solanki
2024-02-13 21:58 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®