* [PATCH] sparc: select FRAME_POINTER instead of redefining it
@ 2024-02-15 13:57 Masahiro Yamada
2024-02-15 16:47 ` Randy Dunlap
2024-02-16 16:24 ` Andreas Larsson
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2024-02-15 13:57 UTC (permalink / raw)
To: linux-kbuild
Cc: Masahiro Yamada, Andreas Larsson, David S. Miller, linux-kernel,
sparclinux
Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
should select it.
Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
also be selected to avoid the unmet dependency warning.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/sparc/Kconfig.debug | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
index 37e003665de6..d475a056a2e0 100644
--- a/arch/sparc/Kconfig.debug
+++ b/arch/sparc/Kconfig.debug
@@ -8,11 +8,8 @@ config MCOUNT
bool
depends on SPARC64
depends on FUNCTION_TRACER
- default y
-
-config FRAME_POINTER
- bool
- depends on MCOUNT
+ select ARCH_WANT_FRAME_POINTERS
+ select FRAME_POINTER
default y
config HAVE_HARDLOCKUP_DETECTOR_SPARC64
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: select FRAME_POINTER instead of redefining it
2024-02-15 13:57 [PATCH] sparc: select FRAME_POINTER instead of redefining it Masahiro Yamada
@ 2024-02-15 16:47 ` Randy Dunlap
2024-02-16 16:24 ` Andreas Larsson
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-02-15 16:47 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild
Cc: Andreas Larsson, David S. Miller, linux-kernel, sparclinux
On 2/15/24 05:57, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
>
> arch/sparc/Kconfig.debug | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
> index 37e003665de6..d475a056a2e0 100644
> --- a/arch/sparc/Kconfig.debug
> +++ b/arch/sparc/Kconfig.debug
> @@ -8,11 +8,8 @@ config MCOUNT
> bool
> depends on SPARC64
> depends on FUNCTION_TRACER
> - default y
> -
> -config FRAME_POINTER
> - bool
> - depends on MCOUNT
> + select ARCH_WANT_FRAME_POINTERS
> + select FRAME_POINTER
> default y
>
> config HAVE_HARDLOCKUP_DETECTOR_SPARC64
--
#Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sparc: select FRAME_POINTER instead of redefining it
2024-02-15 13:57 [PATCH] sparc: select FRAME_POINTER instead of redefining it Masahiro Yamada
2024-02-15 16:47 ` Randy Dunlap
@ 2024-02-16 16:24 ` Andreas Larsson
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Larsson @ 2024-02-16 16:24 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild; +Cc: David S. Miller, linux-kernel, sparclinux
On 2024-02-15 14:57, Masahiro Yamada wrote:
> Because FRAME_POINTER is defined in lib/Kconfig.debug, the arch Kconfig
> should select it.
>
> Add 'select FRAME_POINTER' to MCOUNT. ARCH_WANT_FRAME_POINTERS must
> also be selected to avoid the unmet dependency warning.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Applied to my for-next branch.
Thanks,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-16 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 13:57 [PATCH] sparc: select FRAME_POINTER instead of redefining it Masahiro Yamada
2024-02-15 16:47 ` Randy Dunlap
2024-02-16 16:24 ` Andreas Larsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®