From: Leonardo Bras <leobras@redhat.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Tony Lindgren" <tony@atomide.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Leonardo Bras" <leobras@redhat.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Shanker Donthineni" <sdonthineni@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [RFC PATCH v2 1/4] irq: Move spurious_deferred bit from BIT(31) to BIT(0)
Date: Fri, 16 Feb 2024 04:59:43 -0300 [thread overview]
Message-ID: <20240216075948.131372-3-leobras@redhat.com> (raw)
In-Reply-To: <20240216075948.131372-2-leobras@redhat.com>
Makes sure the threads_handled reserve a bit for that.
This will be useful in the next patch in this series.
Signed-off-by: Leonardo Bras <leobras@redhat.com>
---
include/linux/irqdesc.h | 9 +++++++++
kernel/irq/manage.c | 4 ++--
kernel/irq/spurious.c | 6 ++----
3 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/include/linux/irqdesc.h b/include/linux/irqdesc.h
index d9451d456a733..62aff209315fe 100644
--- a/include/linux/irqdesc.h
+++ b/include/linux/irqdesc.h
@@ -251,4 +251,13 @@ irq_set_lockdep_class(unsigned int irq, struct lock_class_key *lock_class,
__irq_set_lockdep_class(irq, lock_class, request_class);
}
+#define SPURIOUS_DEFERRED (0x1)
+#define SPURIOUS_DEFERRED_SHIFT (1)
+
+static inline void irq_add_handled(struct irq_desc *desc, int i)
+{
+ i <<= SPURIOUS_DEFERRED_SHIFT;
+ atomic_add(i, &desc->threads_handled);
+}
+
#endif
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1782f90cd8c6c..5bc609c7b728c 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1191,7 +1191,7 @@ irq_forced_thread_fn(struct irq_desc *desc, struct irqaction *action)
local_irq_disable();
ret = action->thread_fn(action->irq, action->dev_id);
if (ret == IRQ_HANDLED)
- atomic_inc(&desc->threads_handled);
+ irq_add_handled(desc, 1);
irq_finalize_oneshot(desc, action);
if (!IS_ENABLED(CONFIG_PREEMPT_RT))
@@ -1212,7 +1212,7 @@ static irqreturn_t irq_thread_fn(struct irq_desc *desc,
ret = action->thread_fn(action->irq, action->dev_id);
if (ret == IRQ_HANDLED)
- atomic_inc(&desc->threads_handled);
+ irq_add_handled(desc, 1);
irq_finalize_oneshot(desc, action);
return ret;
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 02b2daf074414..d92f33b2e31ee 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -267,8 +267,6 @@ try_misrouted_irq(unsigned int irq, struct irq_desc *desc,
return action && (action->flags & IRQF_IRQPOLL);
}
-#define SPURIOUS_DEFERRED 0x80000000
-
void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
{
unsigned int irq;
@@ -312,7 +310,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
if (action_ret == IRQ_WAKE_THREAD) {
int handled;
/*
- * We use bit 31 of thread_handled_last to
+ * We use bit 0 of thread_handled_last to
* denote the deferred spurious detection
* active. No locking necessary as
* thread_handled_last is only accessed here
@@ -328,7 +326,7 @@ void note_interrupt(struct irq_desc *desc, irqreturn_t action_ret)
* returned IRQ_HANDLED since the last
* interrupt happened.
*
- * For simplicity we just set bit 31, as it is
+ * For simplicity we just set bit 0, as it is
* set in threads_handled_last as well. So we
* avoid extra masking. And we really do not
* care about the high bits of the handled
--
2.43.2
next prev parent reply other threads:[~2024-02-16 8:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 7:59 [RFC PATCH v2 0/4] Fix force_irqthread + fast triggered edge-type IRQs Leonardo Bras
2024-02-16 7:59 ` Leonardo Bras [this message]
2024-02-16 7:59 ` [RFC PATCH v2 2/4] irq/spurious: Account for multiple handles in note_interrupt Leonardo Bras
2024-02-16 15:36 ` Andy Shevchenko
2024-02-16 20:18 ` Leonardo Bras
2024-02-16 7:59 ` [RFC PATCH v2 3/4] irq: Introduce IRQ_HANDLED_MANY Leonardo Bras
2024-02-19 9:59 ` Thomas Gleixner
2024-02-19 11:03 ` Thomas Gleixner
2024-02-21 5:39 ` Leonardo Bras
2024-02-21 15:41 ` Thomas Gleixner
2024-02-21 17:04 ` Thomas Gleixner
2024-02-23 4:52 ` Leonardo Bras
2024-02-23 4:37 ` Leonardo Bras
2024-02-23 7:33 ` Thomas Gleixner
2024-11-14 3:40 ` Leonardo Bras
2024-11-14 7:50 ` Andy Shevchenko
2024-11-19 1:15 ` Leonardo Bras
2024-11-19 10:06 ` Andy Shevchenko
2024-12-02 22:53 ` Thomas Gleixner
2024-02-16 7:59 ` [RFC PATCH v2 4/4] tty/serial8250: Make use of IRQ_HANDLED_MANY interface Leonardo Bras
2024-02-16 10:12 ` Ilpo Järvinen
2024-02-16 19:58 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216075948.131372-3-leobras@redhat.com \
--to=leobras@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sdonthineni@nvidia.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®