mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] exec: Delete unnecessary statements in remove_arg_zero()
@ 2024-02-20  5:24 Li kunyu
  2024-02-24  1:08 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Li kunyu @ 2024-02-20  5:24 UTC (permalink / raw)
  To: viro, brauner, ebiederm, keescook
  Cc: linux-fsdevel, linux-mm, linux-kernel, Li kunyu

'ret=0; ' In actual operation, the ret was not modified, so this
sentence can be removed.

Signed-off-by: Li kunyu <kunyu@nfschina.com>
---
 fs/exec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/exec.c b/fs/exec.c
index 7be0527f5ff25..10309a93d9c52 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1747,7 +1747,6 @@ int remove_arg_zero(struct linux_binprm *bprm)
 
 	bprm->p++;
 	bprm->argc--;
-	ret = 0;
 
 out:
 	return ret;
-- 
2.18.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] exec: Delete unnecessary statements in remove_arg_zero()
  2024-02-20  5:24 [PATCH] exec: Delete unnecessary statements in remove_arg_zero() Li kunyu
@ 2024-02-24  1:08 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2024-02-24  1:08 UTC (permalink / raw)
  To: viro, brauner, ebiederm, Li kunyu
  Cc: Kees Cook, linux-fsdevel, linux-mm, linux-kernel

On Tue, 20 Feb 2024 13:24:26 +0800, Li kunyu wrote:
> 'ret=0; ' In actual operation, the ret was not modified, so this
> sentence can be removed.
> 
> 

Applied to for-next/execve, thanks!

[1/1] exec: Delete unnecessary statements in remove_arg_zero()
      https://git.kernel.org/kees/c/d3f0d7bbaefd

Take care,

-- 
Kees Cook


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-24  1:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20  5:24 [PATCH] exec: Delete unnecessary statements in remove_arg_zero() Li kunyu
2024-02-24  1:08 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®