mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] media: usbtv: Remove useless locks in usbtv_video_free()
@ 2024-02-20  8:06 Benjamin Gaignard
  2024-02-20 10:42 ` Tomasz Figa
  2024-02-28  8:45 ` Hans Verkuil
  0 siblings, 2 replies; 4+ messages in thread
From: Benjamin Gaignard @ 2024-02-20  8:06 UTC (permalink / raw)
  To: mchehab, hverkuil-cisco, tfiga
  Cc: linux-media, linux-kernel, kernel, Benjamin Gaignard

Remove locks calls in usbtv_video_free() because
are useless and may led to a deadlock as reported here:
https://syzkaller.appspot.com/x/bisect.txt?x=166dc872180000

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Fixes: c838530d230b ("media: media videobuf2: Be more flexible on the number of queue stored buffers")
---
 drivers/media/usb/usbtv/usbtv-video.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c
index 62a583040cd4..96276358d116 100644
--- a/drivers/media/usb/usbtv/usbtv-video.c
+++ b/drivers/media/usb/usbtv/usbtv-video.c
@@ -963,15 +963,9 @@ int usbtv_video_init(struct usbtv *usbtv)
 
 void usbtv_video_free(struct usbtv *usbtv)
 {
-	mutex_lock(&usbtv->vb2q_lock);
-	mutex_lock(&usbtv->v4l2_lock);
-
 	usbtv_stop(usbtv);
 	vb2_video_unregister_device(&usbtv->vdev);
 	v4l2_device_disconnect(&usbtv->v4l2_dev);
 
-	mutex_unlock(&usbtv->v4l2_lock);
-	mutex_unlock(&usbtv->vb2q_lock);
-
 	v4l2_device_put(&usbtv->v4l2_dev);
 }
-- 
2.40.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-28 11:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20  8:06 [PATCH] media: usbtv: Remove useless locks in usbtv_video_free() Benjamin Gaignard
2024-02-20 10:42 ` Tomasz Figa
2024-02-28  8:45 ` Hans Verkuil
2024-02-28 11:33   ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®