* [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X
@ 2024-02-21 8:34 Guoyi Zhang
2024-02-21 10:58 ` Hans de Goede
2024-02-21 23:05 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Guoyi Zhang @ 2024-02-21 8:34 UTC (permalink / raw)
To: sre, wens, hdegoede; +Cc: Guoyi Zhang, linux-pm, linux-kernel
The ROCK Pi X is a single board computer without batteries using the
AXP288 PMIC where the EFI code does not disable the charger part of
the PMIC causing us to report a discharging battery with a continuously
consumed battery charge to userspace.
Add it to the deny-list to avoid the bogus battery status reporting.
Signed-off-by: Guoyi Zhang <kuoi@bioarchlinux.org>
---
drivers/power/supply/axp288_fuel_gauge.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 3be6f3b10..8f67f5d0d 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -599,6 +599,14 @@ static const struct dmi_system_id axp288_quirks[] = {
},
.driver_data = NULL,
},
+ {
+ /* Radxa ROCK Pi X Single Board Computer */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "ROCK Pi X"),
+ DMI_MATCH(DMI_BOARD_VENDOR, "Radxa"),
+ },
+ .driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
+ },
{
/*
* Various Ace PC/Meegopad/MinisForum/Wintel Mini-PCs/HDMI-sticks
--
2.43.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X
2024-02-21 8:34 [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X Guoyi Zhang
@ 2024-02-21 10:58 ` Hans de Goede
2024-02-21 23:05 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2024-02-21 10:58 UTC (permalink / raw)
To: Guoyi Zhang, sre, wens; +Cc: linux-pm, linux-kernel
Hi,
On 2/21/24 09:34, Guoyi Zhang wrote:
> The ROCK Pi X is a single board computer without batteries using the
> AXP288 PMIC where the EFI code does not disable the charger part of
> the PMIC causing us to report a discharging battery with a continuously
> consumed battery charge to userspace.
>
> Add it to the deny-list to avoid the bogus battery status reporting.
>
> Signed-off-by: Guoyi Zhang <kuoi@bioarchlinux.org>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/power/supply/axp288_fuel_gauge.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index 3be6f3b10..8f67f5d0d 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -599,6 +599,14 @@ static const struct dmi_system_id axp288_quirks[] = {
> },
> .driver_data = NULL,
> },
> + {
> + /* Radxa ROCK Pi X Single Board Computer */
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "ROCK Pi X"),
> + DMI_MATCH(DMI_BOARD_VENDOR, "Radxa"),
> + },
> + .driver_data = (void *)AXP288_QUIRK_NO_BATTERY,
> + },
> {
> /*
> * Various Ace PC/Meegopad/MinisForum/Wintel Mini-PCs/HDMI-sticks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X
2024-02-21 8:34 [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X Guoyi Zhang
2024-02-21 10:58 ` Hans de Goede
@ 2024-02-21 23:05 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2024-02-21 23:05 UTC (permalink / raw)
To: sre, wens, hdegoede, Guoyi Zhang; +Cc: linux-pm, linux-kernel
On Wed, 21 Feb 2024 16:34:25 +0800, Guoyi Zhang wrote:
> The ROCK Pi X is a single board computer without batteries using the
> AXP288 PMIC where the EFI code does not disable the charger part of
> the PMIC causing us to report a discharging battery with a continuously
> consumed battery charge to userspace.
>
> Add it to the deny-list to avoid the bogus battery status reporting.
>
> [...]
Applied, thanks!
[1/1] power: supply: axp288_fuel_gauge: Deny ROCK Pi X
commit: 9e6047c01159697cfd2f9b7788af9fe90fc7f544
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-21 23:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-21 8:34 [PATCH] power: supply: axp288_fuel_gauge: Deny ROCK Pi X Guoyi Zhang
2024-02-21 10:58 ` Hans de Goede
2024-02-21 23:05 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®