* [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero
@ 2024-02-22 10:57 Colin Ian King
2024-02-22 19:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-22 10:57 UTC (permalink / raw)
To: Rafael J . Wysocki, Zhang Rui, Len Brown, linux-acpi
Cc: kernel-janitors, linux-kernel
Static analysis with clang scan build is warning that uninitialized
data is being passed into various functions. Stop these warnings by
initializing temp_decik to zero.
Cleans up clang scan warnings in lines 106, 125, 146 and 164 such as:
drivers/acpi/thermal_lib.c:106:9: warning: 2nd function call argument
is an uninitialized value [core.CallAndMessage]
Kudos to Dan Carpenter for the deeper analysis of this issue.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
V2: just set temp_decik to 0
---
drivers/acpi/thermal_lib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
index 4e0519ca9739..6214d6ebe1fa 100644
--- a/drivers/acpi/thermal_lib.c
+++ b/drivers/acpi/thermal_lib.c
@@ -100,7 +100,7 @@ static int thermal_temp(int error, int temp_decik, int *ret_temp)
*/
int thermal_acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
{
- int temp_decik;
+ int temp_decik = 0;
int ret = acpi_active_trip_temp(adev, id, &temp_decik);
return thermal_temp(ret, temp_decik, ret_temp);
@@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_active_trip_temp);
*/
int thermal_acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
{
- int temp_decik;
+ int temp_decik = 0;
int ret = acpi_passive_trip_temp(adev, &temp_decik);
return thermal_temp(ret, temp_decik, ret_temp);
@@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_passive_trip_temp);
*/
int thermal_acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
{
- int temp_decik;
+ int temp_decik = 0;
int ret = acpi_hot_trip_temp(adev, &temp_decik);
return thermal_temp(ret, temp_decik, ret_temp);
@@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_hot_trip_temp);
*/
int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
{
- int temp_decik;
+ int temp_decik = 0;
int ret = acpi_critical_trip_temp(adev, &temp_decik);
return thermal_temp(ret, temp_decik, ret_temp);
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero
2024-02-22 10:57 [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero Colin Ian King
@ 2024-02-22 19:37 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2024-02-22 19:37 UTC (permalink / raw)
To: Colin Ian King
Cc: Rafael J . Wysocki, Zhang Rui, Len Brown, linux-acpi,
kernel-janitors, linux-kernel
On Thu, Feb 22, 2024 at 11:57 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Static analysis with clang scan build is warning that uninitialized
> data is being passed into various functions. Stop these warnings by
> initializing temp_decik to zero.
>
> Cleans up clang scan warnings in lines 106, 125, 146 and 164 such as:
> drivers/acpi/thermal_lib.c:106:9: warning: 2nd function call argument
> is an uninitialized value [core.CallAndMessage]
>
> Kudos to Dan Carpenter for the deeper analysis of this issue.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>
> V2: just set temp_decik to 0
>
> ---
> drivers/acpi/thermal_lib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 4e0519ca9739..6214d6ebe1fa 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -100,7 +100,7 @@ static int thermal_temp(int error, int temp_decik, int *ret_temp)
> */
> int thermal_acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
> {
> - int temp_decik;
> + int temp_decik = 0;
> int ret = acpi_active_trip_temp(adev, id, &temp_decik);
>
> return thermal_temp(ret, temp_decik, ret_temp);
> @@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_active_trip_temp);
> */
> int thermal_acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
> {
> - int temp_decik;
> + int temp_decik = 0;
> int ret = acpi_passive_trip_temp(adev, &temp_decik);
>
> return thermal_temp(ret, temp_decik, ret_temp);
> @@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_passive_trip_temp);
> */
> int thermal_acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
> {
> - int temp_decik;
> + int temp_decik = 0;
> int ret = acpi_hot_trip_temp(adev, &temp_decik);
>
> return thermal_temp(ret, temp_decik, ret_temp);
> @@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_hot_trip_temp);
> */
> int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
> {
> - int temp_decik;
> + int temp_decik = 0;
> int ret = acpi_critical_trip_temp(adev, &temp_decik);
>
> return thermal_temp(ret, temp_decik, ret_temp);
> --
Applied as 6.9 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-22 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-22 10:57 [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero Colin Ian King
2024-02-22 19:37 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®