mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/5] usb: dwc3-am62: module removal and errata fixes
@ 2024-02-14  9:46 Roger Quadros
  2024-02-14  9:46 ` [PATCH v3 1/5] usb: dwc3-am62: call of_platform_depopulate in .remove() Roger Quadros
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Roger Quadros @ 2024-02-14  9:46 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: nm, r-gunasekaran, afd, b-liu, srk, francesco, linux-usb,
	linux-kernel, devicetree, Roger Quadros

Hi,

This series fixes errors during module removal. It also
implements PHY core voltage selection as per TI recommendation
and workaround for Errata i2409 [1].

The workaround needs PHY2 region to be present in device node.
The device tree patch will be sent later after the DT binding doc
is merged.

[1] - https://www.ti.com/lit/er/sprz487d/sprz487d.pdf

Changelog in each file

v2: https://lore.kernel.org/all/20240205141221.56076-1-rogerq@kernel.org/
v1: https://lore.kernel.org/all/20240201121220.5523-1-rogerq@kernel.org/

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Roger Quadros (5):
      usb: dwc3-am62: call of_platform_depopulate in .remove()
      usb: dwc3-am62: fix error on module removal
      usb: dwc3-am62: Fix PHY core voltage selection
      dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space
      usb: dwc3-am62: add workaround for Errata i2409

 .../devicetree/bindings/usb/ti,am62-usb.yaml       |  8 +++-
 drivers/usb/dwc3/dwc3-am62.c                       | 45 ++++++++++++++++------
 2 files changed, 39 insertions(+), 14 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240206-for-v6-9-am62-usb-errata-3-0-233024ea8e9d

Best regards,
-- 
Roger Quadros <rogerq@kernel.org>


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space
@ 2024-02-01 18:35 Bin Liu
  2024-02-14 11:27 ` [PATCH v3 5/5] usb: dwc3-am62: add workaround for Errata i2409 Andrejs Cainikovs
  0 siblings, 1 reply; 16+ messages in thread
From: Bin Liu @ 2024-02-01 18:35 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Roger Quadros, nm, vigneshr, afd, kristo, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, srk, r-gunasekaran,
	linux-arm-kernel, devicetree, linux-kernel

On Thu, Feb 01, 2024 at 06:18:05PM +0000, Conor Dooley wrote:
> On Thu, Feb 01, 2024 at 06:15:20PM +0000, Conor Dooley wrote:
> > On Thu, Feb 01, 2024 at 02:03:31PM +0200, Roger Quadros wrote:
> > > So far this was not required but due to the newly identified
> > > Errata i2409 [1] we need to poke this register space.
> > > 
> > > [1] https://www.ti.com/lit/er/sprz487d/sprz487d.pdf
> > > 
> > > Signed-off-by: Roger Quadros <rogerq@kernel.org>
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Actually, where is the user for this that actually pokes the register
> space?
> You're adding another register region, so I went to check how you were
> handling that in drivers, but there's no driver patch.

See Roger's another patch set 'Add workaround for Errata i2409' posted
on 16th.

-Bin.

> 
> 
> > 
> > > ---
> > > 
> > > Notes:
> > >     Changelog:
> > >     
> > >     v3 - new patch
> > > 
> > >  Documentation/devicetree/bindings/usb/ti,am62-usb.yaml | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > > index fec5651f5602..c02d9d467d9c 100644
> > > --- a/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > > +++ b/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml
> > > @@ -14,7 +14,9 @@ properties:
> > >      const: ti,am62-usb
> > >  
> > >    reg:
> > > -    maxItems: 1
> > > +    items:
> > > +      - description: USB CFG register space
> > > +      - description: USB PHY2 register space
> > >  
> > >    ranges: true
> > >  
> > > @@ -82,7 +84,8 @@ examples:
> > >  
> > >        usbss1: usb@f910000 {
> > >          compatible = "ti,am62-usb";
> > > -        reg = <0x00 0x0f910000 0x00 0x800>;
> > > +        reg = <0x00 0x0f910000 0x00 0x800>,
> > > +              <0x00 0x0f918000 0x00 0x400>;
> > 
> > Why the double zeros btw?
> > 
> > Cheers,
> > Conor.
> > 
> > >          clocks = <&k3_clks 162 3>;
> > >          clock-names = "ref";
> > >          ti,syscon-phy-pll-refclk = <&wkup_conf 0x4018>;
> > > -- 
> > > 2.34.1
> > > 
> 
> 



^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2024-02-26 13:19 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-14  9:46 [PATCH v3 0/5] usb: dwc3-am62: module removal and errata fixes Roger Quadros
2024-02-14  9:46 ` [PATCH v3 1/5] usb: dwc3-am62: call of_platform_depopulate in .remove() Roger Quadros
2024-02-23 22:14   ` Thinh Nguyen
2024-02-14  9:46 ` [PATCH v3 2/5] usb: dwc3-am62: fix error on module removal Roger Quadros
2024-02-23 22:17   ` Thinh Nguyen
2024-02-23 22:31   ` Thinh Nguyen
2024-02-26 13:19     ` Roger Quadros
2024-02-14  9:46 ` [PATCH v3 3/5] usb: dwc3-am62: Fix PHY core voltage selection Roger Quadros
2024-02-23 22:19   ` Thinh Nguyen
2024-02-14  9:46 ` [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space Roger Quadros
2024-02-14 14:09   ` Rob Herring
2024-02-14  9:46 ` [PATCH v3 5/5] usb: dwc3-am62: add workaround for Errata i2409 Roger Quadros
2024-02-23 22:24   ` Thinh Nguyen
2024-02-23 13:17 ` [PATCH v3 0/5] usb: dwc3-am62: module removal and errata fixes Roger Quadros
2024-02-23 22:25   ` Thinh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2024-02-01 18:35 [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space Bin Liu
2024-02-14 11:27 ` [PATCH v3 5/5] usb: dwc3-am62: add workaround for Errata i2409 Andrejs Cainikovs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®