* [PATCH] mtd: spi-nor: Add Puya Semiconductor chips driver
@ 2024-02-26 9:23 Dmitry Dunaev
2024-02-26 9:28 ` Tudor Ambarus
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Dunaev @ 2024-02-26 9:23 UTC (permalink / raw)
Cc: dunaich, Dmitry Dunaev, Tudor Ambarus, Pratyush Yadav,
Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-kernel, linux-mtd
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
Signed-off-by: Dmitry Dunaev <dunaev@tecon.ru>
---
drivers/mtd/spi-nor/Makefile | 1 +
drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++
2 files changed, 65 insertions(+)
create mode 100644 drivers/mtd/spi-nor/puya.c
diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
index 5e68468b72fc..3e22039d0432 100644
--- a/drivers/mtd/spi-nor/Makefile
+++ b/drivers/mtd/spi-nor/Makefile
@@ -10,6 +10,7 @@ spi-nor-objs += intel.o
spi-nor-objs += issi.o
spi-nor-objs += macronix.o
spi-nor-objs += micron-st.o
+spi-nor-objs += puya.o
spi-nor-objs += spansion.o
spi-nor-objs += sst.o
spi-nor-objs += winbond.o
diff --git a/drivers/mtd/spi-nor/puya.c b/drivers/mtd/spi-nor/puya.c
new file mode 100644
index 000000000000..2198a9ed7101
--- /dev/null
+++ b/drivers/mtd/spi-nor/puya.c
@@ -0,0 +1,64 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024, Tecon MT LLC.
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+/* Puya Semiconductor (Shanghai) Co., Ltd */
+static const struct flash_info puya_nor_parts[] = {
+ {
+ .id = SNOR_ID(0x85, 0x60, 0x10),
+ .name = "p25q05h",
+ .size = SZ_64K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x11),
+ .name = "p25q10h",
+ .size = SZ_128K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x12),
+ .name = "p25q20h",
+ .size = SZ_256K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x13),
+ .name = "p25q40h",
+ .size = SZ_512K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x14),
+ .name = "p25q80h",
+ .size = SZ_1M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x15),
+ .name = "p25q16h",
+ .size = SZ_2M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x16),
+ .name = "p25q32h",
+ .size = SZ_4M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x17),
+ .name = "p25q64h",
+ .size = SZ_8M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x18),
+ .name = "p25q128h",
+ .size = SZ_8M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }
+};
+
+const struct spi_nor_manufacturer spi_nor_puya = {
+ .name = "puya",
+ .parts = puya_nor_parts,
+ .nparts = ARRAY_SIZE(puya_nor_parts),
+};
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add Puya Semiconductor chips driver
2024-02-26 9:23 [PATCH] mtd: spi-nor: Add Puya Semiconductor chips driver Dmitry Dunaev
@ 2024-02-26 9:28 ` Tudor Ambarus
2024-02-26 10:40 ` [PATCH v2] " Dmitry Dunaev
0 siblings, 1 reply; 4+ messages in thread
From: Tudor Ambarus @ 2024-02-26 9:28 UTC (permalink / raw)
To: Dmitry Dunaev
Cc: dunaich, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-kernel, linux-mtd
Hi,
Please read the review feedback from
https://lore.kernel.org/linux-mtd/4d117770-6e0c-412f-ac1a-d9ba84b5b4ba@linaro.org/T/#mbcfaac90f123410a35db7dbeb0464dcb0816e7c7,
it applies to this patch as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] mtd: spi-nor: Add Puya Semiconductor chips driver
2024-02-26 9:28 ` Tudor Ambarus
@ 2024-02-26 10:40 ` Dmitry Dunaev
2024-02-26 10:43 ` Tudor Ambarus
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Dunaev @ 2024-02-26 10:40 UTC (permalink / raw)
Cc: dunaich, Dmitry Dunaev, Tudor Ambarus, Pratyush Yadav,
Michael Walle, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra, linux-kernel, linux-mtd
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
Signed-off-by: Dmitry Dunaev <dunaev@tecon.ru>
---
drivers/mtd/spi-nor/Makefile | 1 +
drivers/mtd/spi-nor/core.c | 1 +
drivers/mtd/spi-nor/core.h | 1 +
drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++
4 files changed, 67 insertions(+)
create mode 100644 drivers/mtd/spi-nor/puya.c
diff --git a/drivers/mtd/spi-nor/Makefile b/drivers/mtd/spi-nor/Makefile
index 5e68468b72fc..3e22039d0432 100644
--- a/drivers/mtd/spi-nor/Makefile
+++ b/drivers/mtd/spi-nor/Makefile
@@ -10,6 +10,7 @@ spi-nor-objs += intel.o
spi-nor-objs += issi.o
spi-nor-objs += macronix.o
spi-nor-objs += micron-st.o
+spi-nor-objs += puya.o
spi-nor-objs += spansion.o
spi-nor-objs += sst.o
spi-nor-objs += winbond.o
diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c
index 4129764fad8c..09ad2142d004 100644
--- a/drivers/mtd/spi-nor/core.c
+++ b/drivers/mtd/spi-nor/core.c
@@ -2045,6 +2045,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = {
&spi_nor_issi,
&spi_nor_macronix,
&spi_nor_micron,
+ &spi_nor_puya,
&spi_nor_st,
&spi_nor_spansion,
&spi_nor_sst,
diff --git a/drivers/mtd/spi-nor/core.h b/drivers/mtd/spi-nor/core.h
index d36c0e072954..93df7a6328ca 100644
--- a/drivers/mtd/spi-nor/core.h
+++ b/drivers/mtd/spi-nor/core.h
@@ -609,6 +609,7 @@ extern const struct spi_nor_manufacturer spi_nor_intel;
extern const struct spi_nor_manufacturer spi_nor_issi;
extern const struct spi_nor_manufacturer spi_nor_macronix;
extern const struct spi_nor_manufacturer spi_nor_micron;
+extern const struct spi_nor_manufacturer spi_nor_puya;
extern const struct spi_nor_manufacturer spi_nor_st;
extern const struct spi_nor_manufacturer spi_nor_spansion;
extern const struct spi_nor_manufacturer spi_nor_sst;
diff --git a/drivers/mtd/spi-nor/puya.c b/drivers/mtd/spi-nor/puya.c
new file mode 100644
index 000000000000..2198a9ed7101
--- /dev/null
+++ b/drivers/mtd/spi-nor/puya.c
@@ -0,0 +1,64 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2024, Tecon MT LLC.
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+/* Puya Semiconductor (Shanghai) Co., Ltd */
+static const struct flash_info puya_nor_parts[] = {
+ {
+ .id = SNOR_ID(0x85, 0x60, 0x10),
+ .name = "p25q05h",
+ .size = SZ_64K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x11),
+ .name = "p25q10h",
+ .size = SZ_128K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x12),
+ .name = "p25q20h",
+ .size = SZ_256K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x13),
+ .name = "p25q40h",
+ .size = SZ_512K,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x14),
+ .name = "p25q80h",
+ .size = SZ_1M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x15),
+ .name = "p25q16h",
+ .size = SZ_2M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x16),
+ .name = "p25q32h",
+ .size = SZ_4M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x17),
+ .name = "p25q64h",
+ .size = SZ_8M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }, {
+ .id = SNOR_ID(0x85, 0x60, 0x18),
+ .name = "p25q128h",
+ .size = SZ_8M,
+ .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+ }
+};
+
+const struct spi_nor_manufacturer spi_nor_puya = {
+ .name = "puya",
+ .parts = puya_nor_parts,
+ .nparts = ARRAY_SIZE(puya_nor_parts),
+};
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] mtd: spi-nor: Add Puya Semiconductor chips driver
2024-02-26 10:40 ` [PATCH v2] " Dmitry Dunaev
@ 2024-02-26 10:43 ` Tudor Ambarus
0 siblings, 0 replies; 4+ messages in thread
From: Tudor Ambarus @ 2024-02-26 10:43 UTC (permalink / raw)
To: Dmitry Dunaev
Cc: dunaich, Pratyush Yadav, Michael Walle, Miquel Raynal,
Richard Weinberger, Vignesh Raghavendra, linux-kernel, linux-mtd
On 26.02.2024 12:40, Dmitry Dunaev wrote:
> Add a SPI NOR manufacturer driver for Puya Semiconductor chips
>
> Signed-off-by: Dmitry Dunaev <dunaev@tecon.ru>
> ---
> drivers/mtd/spi-nor/Makefile | 1 +
> drivers/mtd/spi-nor/core.c | 1 +
> drivers/mtd/spi-nor/core.h | 1 +
> drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 67 insertions(+)
> create mode 100644 drivers/mtd/spi-nor/puya.c
what changed in v2? why do you need these entries? Can you rely instead
on SFDP to initialize these flashes?
Please read: https://docs.kernel.org/driver-api/mtd/spi-nor.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-26 10:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 9:23 [PATCH] mtd: spi-nor: Add Puya Semiconductor chips driver Dmitry Dunaev
2024-02-26 9:28 ` Tudor Ambarus
2024-02-26 10:40 ` [PATCH v2] " Dmitry Dunaev
2024-02-26 10:43 ` Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®