From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, rajvi.jingar@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com
Subject: [PATCH V2 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding
Date: Tue, 27 Feb 2024 16:00:14 -0800 [thread overview]
Message-ID: <20240228000016.1685518-8-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240228000016.1685518-1-david.e.box@linux.intel.com>
Fix errors in the calculation of the start position of the counters and in
the display loop.
Fixes: aad129780bae ("platform/x86/intel/sdsi: Add support for reading the current meter state")
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
V2 - Split of V1 patch 7
tools/arch/x86/intel_sdsi/intel_sdsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c
index def1b9a01738..2acc6be5f5d6 100644
--- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
+++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
@@ -403,15 +403,16 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
return -1;
}
- bec = (void *)(mc) + sizeof(mc);
+ bec = (void *)(mc) + sizeof(*mc);
printf("Number of Feature Counters: %d\n", mc->bundle_length / 8);
- while (count++ < mc->bundle_length / 8) {
+ while (count < mc->bundle_length / 8) {
char feature[5];
feature[4] = '\0';
get_feature(bec[count].encoding, feature);
printf(" %s: %d\n", feature, bec[count].counter);
+ ++count;
}
return 0;
--
2.34.1
next prev parent reply other threads:[~2024-02-28 0:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 0:00 [PATCH V2 0/9] Intel On Demand changes David E. Box
2024-02-28 0:00 ` [PATCH V2 1/9] platform/x86/intel/sdsi: Set message size during writes David E. Box
2024-02-28 2:34 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-02-28 2:38 ` Kuppuswamy Sathyanarayanan
2024-02-28 18:10 ` David E. Box
2024-03-04 13:25 ` Ilpo Järvinen
2024-02-28 20:45 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support David E. Box
2024-03-04 13:26 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-02-28 2:41 ` Kuppuswamy Sathyanarayanan
2024-03-04 13:29 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-02-28 2:54 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 6/9] tools/arch/x86/intel_sdsi: Add missing version field David E. Box
2024-02-28 2:57 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` David E. Box [this message]
2024-02-28 2:58 ` [PATCH V2 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding Kuppuswamy Sathyanarayanan
2024-03-04 13:32 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 8/9] platform/x86/intel/sdsi: Simplify ascii printing David E. Box
2024-02-28 2:59 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 9/9] tools: intel_sdsi: Add current meter support David E. Box
2024-02-28 3:31 ` Kuppuswamy Sathyanarayanan
2024-03-04 13:34 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240228000016.1685518-8-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome