From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "David E. Box" <david.e.box@linux.intel.com>,
rajvi.jingar@linux.intel.com,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH V2 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows
Date: Mon, 4 Mar 2024 15:25:05 +0200 (EET) [thread overview]
Message-ID: <b7b842e8-2609-aa8f-f90a-27a8ee8327cb@linux.intel.com> (raw)
In-Reply-To: <dd9ab7d1-5c03-404a-90c7-7ccbc0fb5c4c@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Tue, 27 Feb 2024, Kuppuswamy Sathyanarayanan wrote:
> On 2/27/24 4:00 PM, David E. Box wrote:
> > The current mailbox commands are either read-only or write-only and the
> > flow is different for each. New commands will need to send and receive
> > data. In preparation for these commands, create a common polling function
> > to handle sending data and receiving in the same transaction.
> >
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > ---
> >
> > V2 - In sdsi_cmd_read() remove unnecessary check for non-zero packet_size
> > in do loop since the loop is exited earlier when packet_size is
> > zero.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2024-03-04 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 0:00 [PATCH V2 0/9] Intel On Demand changes David E. Box
2024-02-28 0:00 ` [PATCH V2 1/9] platform/x86/intel/sdsi: Set message size during writes David E. Box
2024-02-28 2:34 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-02-28 2:38 ` Kuppuswamy Sathyanarayanan
2024-02-28 18:10 ` David E. Box
2024-03-04 13:25 ` Ilpo Järvinen [this message]
2024-02-28 20:45 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support David E. Box
2024-03-04 13:26 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-02-28 2:41 ` Kuppuswamy Sathyanarayanan
2024-03-04 13:29 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-02-28 2:54 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 6/9] tools/arch/x86/intel_sdsi: Add missing version field David E. Box
2024-02-28 2:57 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding David E. Box
2024-02-28 2:58 ` Kuppuswamy Sathyanarayanan
2024-03-04 13:32 ` Ilpo Järvinen
2024-02-28 0:00 ` [PATCH V2 8/9] platform/x86/intel/sdsi: Simplify ascii printing David E. Box
2024-02-28 2:59 ` Kuppuswamy Sathyanarayanan
2024-02-28 0:00 ` [PATCH V2 9/9] tools: intel_sdsi: Add current meter support David E. Box
2024-02-28 3:31 ` Kuppuswamy Sathyanarayanan
2024-03-04 13:34 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b842e8-2609-aa8f-f90a-27a8ee8327cb@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome