* [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
@ 2024-02-29 1:28 Stephen Boyd
2024-02-29 1:45 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stephen Boyd @ 2024-02-29 1:28 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson
Cc: linux-kernel, patches, linux-arm-msm, cros-qcom-dts-watchers
We don't use this pmic pinctrl node on any Trogdor devices. The
AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
anything in the devicetrees that include this file. Disable this device
node in the DTS so that we don't waste time or memory on this device.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 46aaeba28604..774c0647ea19 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -1164,6 +1164,7 @@ &pm6150_gpios {
};
&pm6150l_gpios {
+ status = "disabled"; /* No GPIOs are consumed or configured */
gpio-line-names = "AP_SUSPEND",
"",
"",
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
--
https://chromeos.dev
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
2024-02-29 1:28 [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor Stephen Boyd
@ 2024-02-29 1:45 ` Doug Anderson
2024-02-29 11:53 ` Konrad Dybcio
2024-04-04 21:23 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2024-02-29 1:45 UTC (permalink / raw)
To: Stephen Boyd
Cc: Konrad Dybcio, Bjorn Andersson, linux-kernel, patches,
linux-arm-msm, cros-qcom-dts-watchers
Hi,
On Wed, Feb 28, 2024 at 5:28 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
2024-02-29 1:28 [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor Stephen Boyd
2024-02-29 1:45 ` Doug Anderson
@ 2024-02-29 11:53 ` Konrad Dybcio
2024-04-04 21:23 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2024-02-29 11:53 UTC (permalink / raw)
To: Stephen Boyd, Bjorn Andersson
Cc: linux-kernel, patches, linux-arm-msm, cros-qcom-dts-watchers
On 2/29/24 02:28, Stephen Boyd wrote:
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
If you don't use this pmic, perhaps the pins should be explicitly
"parked" instead?
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
2024-02-29 1:28 [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor Stephen Boyd
2024-02-29 1:45 ` Doug Anderson
2024-02-29 11:53 ` Konrad Dybcio
@ 2024-04-04 21:23 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2024-04-04 21:23 UTC (permalink / raw)
To: Konrad Dybcio, Stephen Boyd
Cc: linux-kernel, patches, linux-arm-msm, cros-qcom-dts-watchers
On Wed, 28 Feb 2024 17:28:26 -0800, Stephen Boyd wrote:
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
commit: cb69e758d5918cc03e449e159162e263e8bc7ec1
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-04 21:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-29 1:28 [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor Stephen Boyd
2024-02-29 1:45 ` Doug Anderson
2024-02-29 11:53 ` Konrad Dybcio
2024-04-04 21:23 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®