mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Lee Jones <lee@kernel.org>,
	 Daniel Thompson <daniel.thompson@linaro.org>,
	 Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe()
Date: Mon, 04 Mar 2024 11:11:38 +0100	[thread overview]
Message-ID: <20240304-backlight-probe-v1-1-e5f57d0df6e6@linaro.org> (raw)
In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org>

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/video/backlight/gpio_backlight.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index d28c30b2a35d..9f960f853b6e 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev)
 	def_value = device_property_read_bool(dev, "default-on");
 
 	gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
-	if (IS_ERR(gbl->gpiod)) {
-		ret = PTR_ERR(gbl->gpiod);
-		if (ret != -EPROBE_DEFER)
-			dev_err(dev,
-				"Error: The gpios parameter is missing or invalid.\n");
-		return ret;
-	}
+	if (IS_ERR(gbl->gpiod))
+		return dev_err_probe(dev, PTR_ERR(gbl->gpiod),
+				     "Error: The gpios parameter is missing or invalid.\n");
 
 	memset(&props, 0, sizeof(props));
 	props.type = BACKLIGHT_RAW;

-- 
2.34.1


  reply	other threads:[~2024-03-04 10:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-04 10:11 [PATCH 0/7] backlight: Simplify probe in few drivers Krzysztof Kozlowski
2024-03-04 10:11 ` Krzysztof Kozlowski [this message]
2024-03-04 10:40   ` [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Daniel Thompson
2024-03-05  8:09     ` Krzysztof Kozlowski
2024-03-04 10:11 ` [PATCH 2/7] backlight: l4f00242t03: " Krzysztof Kozlowski
2024-03-04 10:40   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 3/7] backlight: bd6107: Handle deferred probe Krzysztof Kozlowski
2024-03-04 10:41   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 4/7] backlight: as3711_bl: " Krzysztof Kozlowski
2024-03-04 10:42   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 5/7] backlight: lm3630a_bl: " Krzysztof Kozlowski
2024-03-04 10:44   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Krzysztof Kozlowski
2024-03-04 10:46   ` Daniel Thompson
2024-03-04 10:11 ` [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Krzysztof Kozlowski
2024-03-04 11:08   ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304-backlight-probe-v1-1-e5f57d0df6e6@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®